From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Evgeniy Polyakov" <johnpol@2ka.mipt.ru>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: Distributed storage release.
Date: Mon, 13 Oct 2008 16:44:28 +0300 [thread overview]
Message-ID: <84144f020810130644w7f89f3d9m3c3d3e63d3034534@mail.gmail.com> (raw)
In-Reply-To: <20081013133850.GA13565@2ka.mipt.ru>
Hi Evgeniy,
On Mon, Oct 13, 2008 at 4:38 PM, Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
>> > +static void *dst_crypto_thread_init(void *data)
>> > +{
>> > + struct dst_node *n = data;
>> > + struct dst_crypto_engine *e;
>> > + int err = -ENOMEM;
>> > +
>> > + e = kzalloc(sizeof(struct dst_crypto_engine), GFP_KERNEL);
>> > + if (!e)
>> > + goto err_out_exit;
>> > + e->src = kzalloc(sizeof(struct scatterlist) * 2 * n->max_pages,
>> > + GFP_KERNEL);
>>
>> kcalloc()?
>
> What's the difference? In saving one space and replacing another with
> comma? I do not particulary care, but would like to know why it is
> needed :)
kcalloc() will check for multiplication overflow which is nice
especially if size is passed from user-space (not sure if that applies
here).
next prev parent reply other threads:[~2008-10-13 13:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 16:00 Distributed storage release Evgeniy Polyakov
2008-10-13 2:24 ` Andrew Morton
2008-10-13 13:38 ` Evgeniy Polyakov
2008-10-13 13:44 ` Pekka Enberg [this message]
2008-10-13 14:14 ` Evgeniy Polyakov
2008-10-14 15:51 ` Andreas Dilger
2008-10-14 16:12 ` Evgeniy Polyakov
2008-10-14 20:35 ` Andreas Dilger
2008-10-14 21:08 ` Evgeniy Polyakov
2008-10-14 21:23 ` Matthew Wilcox
2008-10-14 21:31 ` Evgeniy Polyakov
-- strict thread matches above, loose matches on Subject: below --
2008-10-13 17:20 Evgeniy Polyakov
2008-10-14 23:23 ` Evgeniy Polyakov
2008-10-14 23:57 ` Evgeniy Polyakov
2008-09-09 11:38 Evgeniy Polyakov
2008-09-10 23:51 ` Sven Wegener
2008-09-11 4:23 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020810130644w7f89f3d9m3c3d3e63d3034534@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=johnpol@2ka.mipt.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).