From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD42EB64DD for ; Fri, 21 Jul 2023 15:08:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231372AbjGUPIV (ORCPT ); Fri, 21 Jul 2023 11:08:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231708AbjGUPIT (ORCPT ); Fri, 21 Jul 2023 11:08:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA1C19B6 for ; Fri, 21 Jul 2023 08:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689952053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2LT31EnQdwzSm3B5EwQJfjJehEaFosn84rDtB5FWxnI=; b=NeF2q5Dk8i5rFoVQkLEDStgFiYvgJ82I4vyKQGQcI8bWDj8UIr6piO4e1oAPj8RbVpeQ8j uEXRDEVpF2vchUqR2OXhD1+1gv2NNwhJVM/KOui09wDGAimv4lupVwcZpczunwmrKcGeFd Vo2h2c34AnjoG1MHu5+MZB49zbmzbZo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-gR76_vDZMjyXazhdY3NEfQ-1; Fri, 21 Jul 2023 11:07:32 -0400 X-MC-Unique: gR76_vDZMjyXazhdY3NEfQ-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-51e3713ce6eso3804116a12.0 for ; Fri, 21 Jul 2023 08:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689952051; x=1690556851; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2LT31EnQdwzSm3B5EwQJfjJehEaFosn84rDtB5FWxnI=; b=iy/lx3xUbkOzqXK8Dx2i6566uzA6RK1k93GCzYiZvv1/Ir5WjBAddY0+ZAASvNbIzj 07geZEUWCtLkIgApJbiCIGwrXYGU4a0SaXSo+LF0bWYAnCkIE1HPiKcmDk8t0cOgjN3U KTecwHyMZ2fzorApkLEqtPdP95HJsf1LGQyCxx7hPKM085VJP3PNkstVVAOQjM7WI6HR Uszk4ZY4hcSMw0eqNlanUnlnNGWtd2H4lg3ds1p1/VN0rgyyd4eDoDBDtuS7i3UlXf6v dFfeKs+Dx1KdVdG+E288KCqTane1n9OgXWArCvZJmhA/iG92cQ08beAPGcZqJ/3BftNO 2EUA== X-Gm-Message-State: ABy/qLajsycYrW6I1tkti8YP9VN0t5mah0T39ZxgFwpXdl8S4vu6fe15 bfroX6T8RxEs8B64CCTYFpXkMRcQkeJ2xuJg1wb8jiEQbDmwGCclgd9UM8UZrpZHfHRm6VYQ2CO Rm7l87qZRmDrQGKhJGAF5kW3NoQ== X-Received: by 2002:a05:6402:3596:b0:521:ae30:787d with SMTP id y22-20020a056402359600b00521ae30787dmr8297803edc.21.1689952051258; Fri, 21 Jul 2023 08:07:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlEmyaXBPPcDeACqrampuhZk7coBp7sKkHctpw4dd03JKW9PMu58s3JgUnfUUPbC+bjZ7T2rgQ== X-Received: by 2002:a05:6402:3596:b0:521:ae30:787d with SMTP id y22-20020a056402359600b00521ae30787dmr8297753edc.21.1689952050947; Fri, 21 Jul 2023 08:07:30 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id w10-20020aa7d28a000000b00521f4ee396fsm127596edq.12.2023.07.21.08.07.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 08:07:30 -0700 (PDT) Message-ID: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Date: Fri, 21 Jul 2023 17:07:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-14-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > u64 flags = args->flags; > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > + I think it should be always allowed. The outcome would just be "never have a hugepage" if thp is not enabled in the kernel. Paolo