From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:52054 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491AbdCaJON (ORCPT ); Fri, 31 Mar 2017 05:14:13 -0400 From: David Howells In-Reply-To: References: <15267.1490891560@warthog.procyon.org.uk> To: Amir Goldstein Cc: dhowells@redhat.com, linux-xfs , Andreas Dilger , Christoph Hellwig , linux-fsdevel , Eric Sandeen , fstests Subject: Re: [PATCH] xfstests: Add first statx test MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8600.1490951650.1@warthog.procyon.org.uk> Date: Fri, 31 Mar 2017 10:14:10 +0100 Message-ID: <8601.1490951650@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Amir Goldstein wrote: > And maybe use the flag "stx_" (without =) to indicate > 'compare statx field > with that of the cmp file'. > So instead of having an all on nothing 'check that the specified file > has identical stats' > tests could be more specific than that. > And maybe a '-a' flag for 'compare all stats'. Would comparing anything other than everything or just timestamps actually be of use, I wonder? David