From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Shmakov Subject: Re: [PATCH 6/6] Rename 'n' into a longer variable name. Date: Tue, 16 Aug 2011 18:42:58 +0700 Message-ID: <8662lx4m65.fsf@gray.siamics.net> References: <20110816112536.1808464.7174.stgit@fsdevel3> <20110816112607.1808464.44359.stgit@fsdevel3> Reply-To: Ivan Shmakov Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE To: linux-fsdevel@vger.kernel.org Return-path: Received: from lo.gmane.org ([80.91.229.12]:36656 "EHLO lo.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984Ab1HPLuI (ORCPT ); Tue, 16 Aug 2011 07:50:08 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QtI9l-0007hD-M3 for linux-fsdevel@vger.kernel.org; Tue, 16 Aug 2011 13:50:05 +0200 Received: from gray.am-1.org ([188.120.231.229]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 16 Aug 2011 13:50:05 +0200 Received: from oneingray by gray.am-1.org with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 16 Aug 2011 13:50:05 +0200 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: >>>>> Bernd Schubert writes: > When it comes to me variable names consisting of a single letter > should be forbidden by coding style guide lines, as it is rather > difficult to search for single letter, such as 'n'. The incremental regexp search in GNU Emacs (M-C-s, M-C-r) copes with that just fine. The regexp I'd use is: \. FWIW, I tend to use shorter (including one-character) names for the variables of narrow (less than a screenful of code) scope. OTOH, for the globals, and structure members, I'd certainly prefer more verbose (and descriptive) names. > Rename struct neighbour *n to dst_neigh [=E2=80=A6] --=20 =46SF associate member #7257 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html