From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A942EC433FE for ; Fri, 29 Oct 2021 22:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E21A61040 for ; Fri, 29 Oct 2021 22:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbhJ2W0m (ORCPT ); Fri, 29 Oct 2021 18:26:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbhJ2W0j (ORCPT ); Fri, 29 Oct 2021 18:26:39 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19F8AC061570; Fri, 29 Oct 2021 15:24:09 -0700 (PDT) Received: from localhost (unknown [IPv6:2804:14c:124:8a08::1002]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: krisman) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 4CC991F45CD8; Fri, 29 Oct 2021 23:24:04 +0100 (BST) From: Gabriel Krisman Bertazi To: Amir Goldstein Cc: Jan Kara , Jan Kara , "Darrick J. Wong" , Theodore Tso , Dave Chinner , David Howells , Khazhismel Kumykov , linux-fsdevel , Linux API , Ext4 , kernel@collabora.com, Jeff Layton , andres@anarazel.de Subject: Re: [PATCH v9 00/31] file system-wide error monitoring Organization: Collabora References: <20211025192746.66445-1-krisman@collabora.com> <20211027112243.GE28650@quack2.suse.cz> <87y26ed3hq.fsf@collabora.com> Date: Fri, 29 Oct 2021 19:23:55 -0300 In-Reply-To: (Amir Goldstein's message of "Thu, 28 Oct 2021 08:55:02 +0300") Message-ID: <8735oja2ro.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Amir Goldstein writes: >> Also, thank you both for the extensive review and ideas during the >> development of this series. It was really appreciated! >> > > Thank you for your appreciated effort! > It was a wild journey through some interesting experiments, but > you survived it well ;-) > > Would you be interested in pursuing FAN_WB_ERROR after a due rest > and after all the dust on FAN_FS_ERROR has settled? I think it would make sense for me to continue working on it, yes. But, before that, I think I still have some support to add to FAN_FS_ERROR, like a detailed, fs-specific, info record, and an error location info record, which has a use-case in Google Cloud environments. I have to discuss priorities internally, but we (collabora) do have an interest in supporting WB_ERROR too. For the detailed error report, fanotify could have a new info record that carries a structure sent out by the file system. fanotify could handle the lifetime of this object, by keeping a larger mempool, or delegate its allocation/destruction to the filesystem. Like I proposed in an earlier version of FAN_FS_ERROR, the format could be as simple as: struct fanotify_error_data_info { struct fanotify_event_info_header hdr; char data[]; } I think xfs, at least, would be able to make good use of this record with xfs_scrub, as the xfs maintainers mentioned. -- Gabriel Krisman Bertazi