From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_00, CHARSET_FARAWAY_HEADER,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 599D7C48BE6 for ; Wed, 16 Jun 2021 08:12:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22D5761159 for ; Wed, 16 Jun 2021 08:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231652AbhFPION (ORCPT ); Wed, 16 Jun 2021 04:14:13 -0400 Received: from regular1.263xmail.com ([211.150.70.201]:37114 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231481AbhFPION (ORCPT ); Wed, 16 Jun 2021 04:14:13 -0400 Received: from localhost (unknown [192.168.167.32]) by regular1.263xmail.com (Postfix) with ESMTP id 2C0E2F6A; Wed, 16 Jun 2021 16:11:53 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from manjaro.uniontech.com (unknown [58.246.122.242]) by smtp.263.net (postfix) whith ESMTP id P24497T139649611695872S1623831111955692_; Wed, 16 Jun 2021 16:11:52 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <6dac89850f76a041949d0214cc278a3c> X-RL-SENDER: chenli@uniontech.com X-SENDER: chenli@uniontech.com X-LOGIN-NAME: chenli@uniontech.com X-FST-TO: hch@infradead.org X-RCPT-COUNT: 6 X-SENDER-IP: 58.246.122.242 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Date: Wed, 16 Jun 2021 16:11:52 +0800 Message-ID: <8735tigref.wl-chenli@uniontech.com> From: Chen Li To: Christoph Hellwig Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner , Andrew Morton Subject: Re: [PATCH] ramfs: skip mknod if inode already =?GB2312?B?ZXhp?= =?GB2312?B?c3RzLqG+x+vXotLio6zTyrz+08liYXR2K2FlODk4OWUxNjY4Zjg0YTc0ZDM3?= =?GB2312?B?KzY1MDYraW5mcmFkZWFkLm9yZytoY2hAY2FzcGVyLnNycy5pbmZyYWRlYWQu?= =?GB2312?B?b3JntPq3oqG/?= In-Reply-To: References: <874kdyh65j.wl-chenli@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, 16 Jun 2021 13:10:25 +0800, Christoph Hellwig wrote: > > On Wed, Jun 16, 2021 at 10:53:12AM +0800, Chen Li wrote: > > > > It's possible we try to mknod a dentry, which have > > already bound to an inode, just skip it. > > How do you think this could happen? > > Sorry, that's my bad. I noticed unionfs used to do this check in 9c5b4452998c6e670cfde0928b277e9c50d9a676, but not sure is it a must.