From: "Aurélien Aptel" <aaptel@suse.com>
To: Miklos Szeredi <miklos@szeredi.hu>, Al Viro <viro@zeniv.linux.org.uk>
Cc: Karel Zak <kzak@redhat.com>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] proc/mounts: add cursor
Date: Thu, 09 Apr 2020 18:22:21 +0200 [thread overview]
Message-ID: <87369ceiiq.fsf@suse.com> (raw)
In-Reply-To: <20200409141619.GF28467@miu.piliscsaba.redhat.com>
Miklos Szeredi <miklos@szeredi.hu> writes:
>
> +static inline void lock_ns_list(struct mnt_namespace *ns)
> +{
> + spin_lock(&ns->ns_lock);
> +}
> +
> +static inline void unlock_ns_list(struct mnt_namespace *ns)
> +{
> + spin_unlock(&ns->ns_lock);
> +}
> +
You could add __acquires sparse annotations for those functions. See:
https://www.kernel.org/doc/html/v5.6/dev-tools/sparse.html#using-sparse-for-lock-checking
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2020-04-09 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 14:16 [PATCH v2] proc/mounts: add cursor Miklos Szeredi
2020-04-09 16:22 ` Aurélien Aptel [this message]
2020-04-09 16:50 ` Al Viro
2020-04-09 16:54 ` Al Viro
2020-04-09 18:30 ` Al Viro
2020-04-09 19:36 ` Miklos Szeredi
2020-04-09 18:45 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87369ceiiq.fsf@suse.com \
--to=aaptel@suse.com \
--cc=kzak@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).