From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D04CC2BA2B for ; Thu, 9 Apr 2020 16:22:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B64A20768 for ; Thu, 9 Apr 2020 16:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726683AbgDIQWY convert rfc822-to-8bit (ORCPT ); Thu, 9 Apr 2020 12:22:24 -0400 Received: from mx2.suse.de ([195.135.220.15]:60346 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbgDIQWY (ORCPT ); Thu, 9 Apr 2020 12:22:24 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8DD00AC1D; Thu, 9 Apr 2020 16:22:22 +0000 (UTC) From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: Miklos Szeredi , Al Viro Cc: Karel Zak , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2] proc/mounts: add cursor In-Reply-To: <20200409141619.GF28467@miu.piliscsaba.redhat.com> References: <20200409141619.GF28467@miu.piliscsaba.redhat.com> Date: Thu, 09 Apr 2020 18:22:21 +0200 Message-ID: <87369ceiiq.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Miklos Szeredi writes: > > +static inline void lock_ns_list(struct mnt_namespace *ns) > +{ > + spin_lock(&ns->ns_lock); > +} > + > +static inline void unlock_ns_list(struct mnt_namespace *ns) > +{ > + spin_unlock(&ns->ns_lock); > +} > + You could add __acquires sparse annotations for those functions. See: https://www.kernel.org/doc/html/v5.6/dev-tools/sparse.html#using-sparse-for-lock-checking -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)