From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org,
Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 11/17] unicode: remove MODULE_LICENSE in non-modules
Date: Mon, 06 Mar 2023 10:32:53 -0500 [thread overview]
Message-ID: <874jqxrj2y.fsf@suse.de> (raw)
In-Reply-To: <20230302211759.30135-12-nick.alcock@oracle.com> (Nick Alcock's message of "Thu, 2 Mar 2023 21:17:53 +0000")
Nick Alcock <nick.alcock@oracle.com> writes:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: Gabriel Krisman Bertazi <krisman@collabora.com>
> Cc: linux-fsdevel@vger.kernel.org
> ---
Acked-by: Gabriel Krisman Bertazi <krisman@suse.de>
Thanks,
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2023-03-06 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 21:17 [PATCH 00/17] MODULE_LICENSE removals, sixth tranche Nick Alcock
2023-03-02 21:17 ` [PATCH 11/17] unicode: remove MODULE_LICENSE in non-modules Nick Alcock
2023-03-06 15:32 ` Gabriel Krisman Bertazi [this message]
2023-03-03 22:22 ` [PATCH 00/17] MODULE_LICENSE removals, sixth tranche Luis Chamberlain
2023-03-20 11:00 ` Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jqxrj2y.fsf@suse.de \
--to=krisman@suse.de \
--cc=hasegawa-hitomi@fujitsu.com \
--cc=krisman@collabora.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).