From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: "M. Mohan Kumar" <mohan@in.ibm.com>,
v9fs-developer@lists.sourceforge.net
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/9p: Use updated offset for writing
Date: Wed, 16 Mar 2011 13:35:46 +0530 [thread overview]
Message-ID: <874o73ij6t.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1300252156-5002-1-git-send-email-mohan@in.ibm.com>
On Wed, 16 Mar 2011 10:39:16 +0530, "M. Mohan Kumar" <mohan@in.ibm.com> wrote:
> Use the updated offset given by generic_write_checks. Without this fix,
> even if a file is opened in O_APPEND mode, data will be written at current
> file position instead of end of file.
>
> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
> ---
> fs/9p/vfs_file.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 6997eb6..51049cd 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -510,7 +510,7 @@ v9fs_file_write(struct file *filp, const char __user * data,
>
> return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
> filp->private_data,
> - data, count, offset, 1);
> + data, count, &origin, 1);
> out:
> return retval;
> }
You should also update offset on success.
-aneesh
next prev parent reply other threads:[~2011-03-16 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 5:09 [PATCH] fs/9p: Use updated offset for writing M. Mohan Kumar
2011-03-16 8:05 ` Aneesh Kumar K. V [this message]
2011-03-16 11:18 ` M. Mohan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o73ij6t.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohan@in.ibm.com \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).