From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K. V" Subject: Re: [PATCH -V11 1/9] exportfs: Return the minimum required handle size Date: Sat, 22 May 2010 14:02:23 +0530 Message-ID: <874oi02v6w.fsf@linux.vnet.ibm.com> References: <1274340938-29628-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1274340938-29628-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20100521221516.GD13227@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, viro@zeniv.linux.org.uk, adilger@sun.com, corbet@lwn.net, serue@us.ibm.com, neilb@suse.de, hooanon05@yahoo.co.jp, linux-fsdevel@vger.kernel.org, sfrench@us.ibm.com, philippe.deniel@CEA.FR, linux-kernel@vger.kernel.org To: "J. Bruce Fields" Return-path: In-Reply-To: <20100521221516.GD13227@fieldses.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 21 May 2010 18:15:16 -0400, "J. Bruce Fields" wrote: > On Thu, May 20, 2010 at 01:05:30PM +0530, Aneesh Kumar K.V wrote: > > The exportfs encode handle function should return the minimum required > > handle size. This helps user to find out the handle size by passing 0 > > handle size in the first step and then redoing to the call again with > > the returned handle size value. > > The encode_fh() interface is a little confusing. (Not your fault, > really, mainly it's the return value (and the special use of 255) that I > always find odd.) > > But maybe it would help to have a little more documention in the > export_encode_fh() kerneldoc comment and/or in > Documentation/filesystems/nfs/Exporting? > Will update in the next iteration. -aneesh