From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>, Andreas Dilger <adilger@sun.com>
Cc: hch@infradead.org, viro@zeniv.linux.org.uk, corbet@lwn.net,
serue@us.ibm.com, linux-fsdevel@vger.kernel.org,
sfrench@us.ibm.com
Subject: Re: [PATCH -V4 2/6] vfs: Add name to file handle conversion support
Date: Mon, 26 Apr 2010 15:44:41 +0530 [thread overview]
Message-ID: <874oiyplke.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100426095208.GA23020@infradead.org>
On Mon, 26 Apr 2010 05:52:08 -0400, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, Apr 23, 2010 at 04:02:14PM -0600, Andreas Dilger wrote:
> > Out of curiosity, why not do this for other types of files? It makes sense from a consistency POV, so that the userspace code doesn't have to special-case each file by checking the type first (which would mean doing an extra path traversal and stat for each file first, adding overhead).
>
> This limitation seems to be copied from the original XFS handle code,
> but I don't see any good reason to stay with it.
>
The limitation came from the original XFS handle code. So to support
symlink and regular files better i added the below syscalls to the patch
set. sys_name_to_handle, sys_lname_to_handle and sys_freadlink. The last
to return the link target name from an fd. This enables to use handle
for symlink and then use the fd returned from open_by_handle to get the
target name. Let me know what you think
-aneesh
next prev parent reply other threads:[~2010-04-26 10:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 11:38 [PATCH -V4] Generic name to handle and open by handle syscalls Aneesh Kumar K.V
2010-04-23 11:38 ` [PATCH -V4 1/6] exportfs: Return the minimum required handle size Aneesh Kumar K.V
2010-04-23 11:38 ` [PATCH -V4 2/6] vfs: Add name to file handle conversion support Aneesh Kumar K.V
2010-04-23 22:02 ` Andreas Dilger
2010-04-26 9:52 ` Christoph Hellwig
2010-04-26 10:14 ` Aneesh Kumar K. V [this message]
2010-04-26 10:12 ` Aneesh Kumar K. V
2010-04-26 17:57 ` J. Bruce Fields
2010-04-27 6:13 ` Aneesh Kumar K. V
2010-04-27 13:28 ` J. Bruce Fields
2010-04-23 11:38 ` [PATCH -V4 3/6] vfs: Add open by file handle support Aneesh Kumar K.V
2010-04-23 11:38 ` [PATCH -V4 4/6] ext4: Add get_fsid callback Aneesh Kumar K.V
2010-04-23 11:38 ` [PATCH -V4 5/6] x86: Add new syscalls for x86_32 Aneesh Kumar K.V
2010-04-23 11:38 ` [PATCH -V4 6/6] x86: Add new syscalls for x86_64 Aneesh Kumar K.V
2010-04-23 22:09 ` Andreas Dilger
2010-04-25 18:28 ` Aneesh Kumar K. V
2010-04-26 9:53 ` Christoph Hellwig
2010-04-26 17:59 ` Andreas Dilger
2010-04-27 6:25 ` Aneesh Kumar K. V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874oiyplke.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@sun.com \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sfrench@us.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).