From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 2/3] quota: introduce get_id callback Date: Wed, 03 Feb 2010 08:38:15 +0300 Message-ID: <874olyg9q0.fsf@openvz.org> References: <1265122826-5370-1-git-send-email-dmonakhov@openvz.org> <1265122826-5370-2-git-send-email-dmonakhov@openvz.org> <1265122826-5370-3-git-send-email-dmonakhov@openvz.org> <20100202160509.GI7056@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from mailhub.sw.ru ([195.214.232.25]:33698 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753321Ab0BCFiX (ORCPT ); Wed, 3 Feb 2010 00:38:23 -0500 In-Reply-To: <20100202160509.GI7056@quack.suse.cz> (Jan Kara's message of "Tue, 2 Feb 2010 17:05:09 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jan Kara writes: > On Tue 02-02-10 18:00:24, Dmitry Monakhov wrote: >> During some quota oparations we have to determine quota_id for given inode >> according to quota_type. But only USRQUOTA/GRPQUOTA id are intermediately >> accessible from generic vfs-inode. This patch introduce new per_sb quota >> operation for this purpose. > Hmm, but you do not intend to ever change what is returned for USRQUOTA > and GRPQUOTA, do you? So we could just have something like Hmm... In fact i've considered this option. For example: In case of containers(trees), each container administrator want user/group quota to work inside it's container. I've considered following approach: 1) enlarge qid_t to u64 2) encode quota_uid and group_uid like follows: quid = treeid << 32 + uid qgid = treeid << 32 + gid 3) Introduce new 64-bit quota format file to support wide qid_t. Currently i dont know better way to support user/group quota inside tree. It does not affect old fs-internal code, just replace all hard-coded (int => u64) in fs/quota-XXX. Old 32-bit quota users not affected because qid_t will be shrink ed on quota-save for old(most of) users.