Re: [PATCH] [net/9p] Change wake_up to wake_up_all() in the virtio transport.

["Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>]

On Tue,  8 Mar 2011 15:39:24 -0800, "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com> wrote:
> This fix wakes up all the threads waiting for the space on VirtIO
> ring.

It would be nice to document in commit message what error you
saw without the change. Is it that the tasks were waiting even though
there was space in the virtio ring because they didn't get woken up ?

> 
> Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
> ---
>  net/9p/trans_virtio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> index 9b550ed..e90e954 100644
> --- a/net/9p/trans_virtio.c
> +++ b/net/9p/trans_virtio.c
> @@ -148,7 +148,7 @@ static void req_done(struct virtqueue *vq)
>  		if (rc != NULL) {
>  			if (!chan->ring_bufs_avail) {
>  				chan->ring_bufs_avail = 1;
> -				wake_up(chan->vc_wq);
> +				wake_up_all(chan->vc_wq);
>  			}
>  			spin_unlock_irqrestore(&chan->lock, flags);
>  			P9_DPRINTK(P9_DEBUG_TRANS, ": rc %p\n", rc);
> -- 

-aneesh