From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K. V" Subject: Re: [PATCH] [net/9p] Change wake_up to wake_up_all() in the virtio transport. Date: Wed, 09 Mar 2011 14:47:27 +0530 Message-ID: <877hc8sleg.fsf@linux.vnet.ibm.com> References: <1299627564-4204-1-git-send-email-jvrao@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, "Venkateswararao Jujjuri \(JV\)" To: "Venkateswararao Jujjuri \(JV\)" , v9fs-developer@lists.sourceforge.net Return-path: Received: from e23smtp09.au.ibm.com ([202.81.31.142]:40838 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757072Ab1CIJRc (ORCPT ); Wed, 9 Mar 2011 04:17:32 -0500 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246]) by e23smtp09.au.ibm.com (8.14.4/8.13.1) with ESMTP id p299HVWM018120 for ; Wed, 9 Mar 2011 20:17:31 +1100 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p299HU5m2306110 for ; Wed, 9 Mar 2011 20:17:30 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p299HUUh029242 for ; Wed, 9 Mar 2011 20:17:30 +1100 In-Reply-To: <1299627564-4204-1-git-send-email-jvrao@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 8 Mar 2011 15:39:24 -0800, "Venkateswararao Jujjuri (JV)" wrote: > This fix wakes up all the threads waiting for the space on VirtIO > ring. It would be nice to document in commit message what error you saw without the change. Is it that the tasks were waiting even though there was space in the virtio ring because they didn't get woken up ? > > Signed-off-by: Venkateswararao Jujjuri > --- > net/9p/trans_virtio.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c > index 9b550ed..e90e954 100644 > --- a/net/9p/trans_virtio.c > +++ b/net/9p/trans_virtio.c > @@ -148,7 +148,7 @@ static void req_done(struct virtqueue *vq) > if (rc != NULL) { > if (!chan->ring_bufs_avail) { > chan->ring_bufs_avail = 1; > - wake_up(chan->vc_wq); > + wake_up_all(chan->vc_wq); > } > spin_unlock_irqrestore(&chan->lock, flags); > P9_DPRINTK(P9_DEBUG_TRANS, ": rc %p\n", rc); > -- -aneesh