linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Venkateswararao Jujjuri \(JV\)" <jvrao@linux.vnet.ibm.com>,
	v9fs-developer@lists.sourceforge.net
Cc: linux-fsdevel@vger.kernel.org, ericvh@gmail.com,
	"Venkateswararao Jujjuri \(JV\)" <jvrao@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/3] [net/9p] Fix the size of receive buffer packing onto VirtIO ring.
Date: Fri, 01 Jul 2011 16:51:32 +0530	[thread overview]
Message-ID: <878vsint4z.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1309475921-12171-1-git-send-email-jvrao@linux.vnet.ibm.com>

On Thu, 30 Jun 2011 16:18:39 -0700, "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com> wrote:
> Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
> ---
>  net/9p/trans_virtio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> index 244e707..0ec5423 100644
> --- a/net/9p/trans_virtio.c
> +++ b/net/9p/trans_virtio.c
> @@ -367,7 +367,7 @@ req_retry_pinned:
>  		in += inp;
>  	} else {
>  		in = pack_sg_list(chan->sg, out, VIRTQUEUE_NUM, rdata,
> -				client->msize);
> +				req->rc->capacity);
>  	}
> 
>  	err = virtqueue_add_buf(chan->vq, chan->sg, out, in, req->tc);

So when will req->rc->capacity be different from client->msize ? Can we
get details for that documented in p9_tag_alloc ?

The above pack_sg_list will only be called for non-zero copy case ? In
that case won't client->size be same as rc->capacity ?

-aneesh

  parent reply	other threads:[~2011-07-01 11:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 23:18 [PATCH 1/3] [net/9p] Fix the size of receive buffer packing onto VirtIO ring Venkateswararao Jujjuri (JV)
2011-06-30 23:18 ` [PATCH 2/3] [net/9p] Fix the msize calculation Venkateswararao Jujjuri (JV)
2011-07-01 11:14   ` Aneesh Kumar K.V
2011-06-30 23:18 ` [PATCH 3/3] [net/9p] VirtIO can transfer VIRTQUEUE_NUM of pages Venkateswararao Jujjuri (JV)
2011-07-01 11:24   ` Aneesh Kumar K.V
2011-07-01 16:27     ` Venkateswararao Jujjuri
2011-07-01 11:21 ` Aneesh Kumar K.V [this message]
2011-07-01 16:29   ` [PATCH 1/3] [net/9p] Fix the size of receive buffer packing onto VirtIO ring Venkateswararao Jujjuri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vsint4z.fsf@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=ericvh@gmail.com \
    --cc=jvrao@linux.vnet.ibm.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).