From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: fscache review comments, part 3 Date: Fri, 06 Oct 2006 14:25:54 +0100 Message-ID: <8798.1160141154@redhat.com> References: <20060928164547.GC3497@infradead.org> Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:58523 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1422654AbWJFN0E (ORCPT ); Fri, 6 Oct 2006 09:26:04 -0400 In-Reply-To: <20060928164547.GC3497@infradead.org> To: Christoph Hellwig Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig wrote: > - generic_file_buffered_write_one_kernel_page seems generally fine, but > you must not call this directly from cachefiles but rather go through > a file operation for it. I can't do that for one very good reason: you insisted that I take out[*] all the provision of a struct file * for doing I/O to the cache, and without that I can't call file ops. You can't have it both ways. Sorry. David [*] You may remember the ENFILE avoidance patch that you objected strenuously to.