From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K. V" Subject: Re: [PATCH -V8 2/9] vfs: Add name to file handle conversion support Date: Tue, 18 May 2010 12:28:20 +0530 Message-ID: <87aarxpugj.fsf@linux.vnet.ibm.com> References: <1274074432-29695-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1274074432-29695-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <7252.1274150030@jrobl> <87fx1ppy21.fsf@linux.vnet.ibm.com> <10947.1274163508@jrobl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: hch@infradead.org, viro@zeniv.linux.org.uk, adilger@sun.com, corbet@lwn.net, serue@us.ibm.com, neilb@suse.de, linux-fsdevel@vger.kernel.org, sfrench@us.ibm.com, philippe.deniel@CEA.FR, linux-kernel@vger.kernel.org To: "J. R. Okajima" Return-path: In-Reply-To: <10947.1274163508@jrobl> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 18 May 2010 15:18:28 +0900, "J. R. Okajima" wrote: > > "Aneesh Kumar K. V": > > The file_handle I mentioned above is the file handle returned by > > sys_name_to_handle_at syscall. NFS kernel server won't be using the > > interface. > > Thanx clarifying. > I think I should read the notes in the first description (0/9) before > posting. > It says UUID is just for userspace. > > Reading all 9 patches, I noticed handle_to_path() calls > exportfs_decode_fh() inconditionally. > Since exportfs_decode_fh() calls s_export_op->fh_to_dentry() > inconditionally too, handle_to_path() will crash when the target FS > doesn't support NFS-exporting, won't it? > I guess we should fix exprtfs_decode_fh to return -ESTALE if fh_to_dentry is NULL -aneesh