From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F3AC4338F for ; Mon, 23 Aug 2021 14:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88E0761378 for ; Mon, 23 Aug 2021 14:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbhHWOwf (ORCPT ); Mon, 23 Aug 2021 10:52:35 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47240 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbhHWOwe (ORCPT ); Mon, 23 Aug 2021 10:52:34 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id BDE0D1F4260E From: Gabriel Krisman Bertazi To: Christoph Hellwig Cc: Shreeya Patel , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 01/11] ext4: simplify ext4_sb_read_encoding Organization: Collabora References: <20210818140651.17181-1-hch@lst.de> <20210818140651.17181-2-hch@lst.de> Date: Mon, 23 Aug 2021 10:51:45 -0400 In-Reply-To: <20210818140651.17181-2-hch@lst.de> (Christoph Hellwig's message of "Wed, 18 Aug 2021 16:06:41 +0200") Message-ID: <87bl5o2ozi.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Christoph Hellwig writes: > Return the encoding table as the return value instead of as an argument, > and don't bother with the encoding flags as the caller can handle that > trivially. > > Signed-off-by: Christoph Hellwig Looks good to me. Feel free to add Reviewed-by: Gabriel Krisman Bertazi -- Gabriel Krisman Bertazi