From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH 2/3] [net/9p] Fix the msize calculation. Date: Fri, 01 Jul 2011 16:44:10 +0530 Message-ID: <87boxenth9.fsf@linux.vnet.ibm.com> References: <1309475921-12171-1-git-send-email-jvrao@linux.vnet.ibm.com> <1309475921-12171-2-git-send-email-jvrao@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, ericvh@gmail.com, "Venkateswararao Jujjuri \(JV\)" To: "Venkateswararao Jujjuri \(JV\)" , v9fs-developer@lists.sourceforge.net Return-path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:46851 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754854Ab1GALOa (ORCPT ); Fri, 1 Jul 2011 07:14:30 -0400 Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116]) by e5.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p61AjwZm028880 for ; Fri, 1 Jul 2011 06:45:58 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p61BEJeY1609918 for ; Fri, 1 Jul 2011 07:14:19 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p61BEHBb011662 for ; Fri, 1 Jul 2011 07:14:18 -0400 In-Reply-To: <1309475921-12171-2-git-send-email-jvrao@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 30 Jun 2011 16:18:40 -0700, "Venkateswararao Jujjuri (JV)" wrote: > msize represents the maximum PDU size that includes P9_IOHDRSZ. > > Signed-off-by: Venkateswararao Jujjuri " > --- > net/9p/client.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/9p/client.c b/net/9p/client.c > index 9e3b0e6..1b89351 100644 > --- a/net/9p/client.c > +++ b/net/9p/client.c > @@ -821,8 +821,8 @@ struct p9_client *p9_client_create(const char *dev_name, char *options) > if (err) > goto destroy_fidpool; > > - if ((clnt->msize+P9_IOHDRSZ) > clnt->trans_mod->maxsize) > - clnt->msize = clnt->trans_mod->maxsize-P9_IOHDRSZ; > + if (clnt->msize > clnt->trans_mod->maxsize) > + clnt->msize = clnt->trans_mod->maxsize; > > err = p9_client_version(clnt); > if (err) Reviewed-by: Aneesh Kumar K.V -aneesh