linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Monakhov <dmonakhov@openvz.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org,
	Evgeniy Polyakov <zbr@ioremap.net>
Subject: [PATCH] pohmelfs: Remove dead quota code
Date: Fri, 21 May 2010 11:37:32 +0400	[thread overview]
Message-ID: <87bpc9wvr7.fsf@openvz.org> (raw)
In-Reply-To: <1274386643-24033-1-git-send-email-jack@suse.cz> (Jan Kara's message of "Thu, 20 May 2010 22:17:21 +0200")

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Jan Kara <jack@suse.cz> writes:

>   Two patches below remove dead quota code from UFS and UDF. Quota is
> non-functional (quotaon fails) for these filesystems for several years and
> noone complained AFAIK. Also the main purpose of these filesystems is
> interoperability with other systems and quota support is linux-specific so it
> does not make too much sense. So remove the dead code...
Awesome. Let's remove dead quota code completely.

[-- Attachment #2: 0001-pohmelfs-Remove-dead-quota-code.patch --]
[-- Type: text/plain, Size: 1278 bytes --]

>From e6095c822e076b426b6684901f9c7a824cdab0d9 Mon Sep 17 00:00:00 2001
From: root <root@dws1.(none)>
Date: Fri, 21 May 2010 11:16:10 +0400
Subject: [PATCH] pohmelfs: Remove dead quota code

Quota on pohmelfs is non-functional. IFAIU quota logic was copy-pasted
from generic setattr().

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 drivers/staging/pohmelfs/inode.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
index 11fc4d5..9123837 100644
--- a/drivers/staging/pohmelfs/inode.c
+++ b/drivers/staging/pohmelfs/inode.c
@@ -29,7 +29,6 @@
 #include <linux/slab.h>
 #include <linux/statfs.h>
 #include <linux/writeback.h>
-#include <linux/quotaops.h>
 
 #include "netfs.h"
 
@@ -967,13 +966,6 @@ int pohmelfs_setattr_raw(struct inode *inode, struct iattr *attr)
 		goto err_out_exit;
 	}
 
-	if ((attr->ia_valid & ATTR_UID && attr->ia_uid != inode->i_uid) ||
-	    (attr->ia_valid & ATTR_GID && attr->ia_gid != inode->i_gid)) {
-		err = dquot_transfer(inode, attr);
-		if (err)
-			goto err_out_exit;
-	}
-
 	err = inode_setattr(inode, attr);
 	if (err) {
 		dprintk("%s: ino: %llu, failed to set the attributes.\n", __func__, POHMELFS_I(inode)->ino);
-- 
1.6.2.5


  parent reply	other threads:[~2010-05-21  7:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-20 20:17 [PATCH 0/2] Remove dead quota code Jan Kara
2010-05-20 20:17 ` [PATCH 1/2] udf: " Jan Kara
2010-05-20 20:17 ` [PATCH 2/2] ufs: " Jan Kara
2010-05-21  7:37 ` Dmitry Monakhov [this message]
2010-05-21 14:39   ` [PATCH] pohmelfs: " Evgeniy Polyakov
2010-05-21 16:05   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bpc9wvr7.fsf@openvz.org \
    --to=dmonakhov@openvz.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).