From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 5/6] ceph: refactor mount related functions, add helpers
Date: Wed, 14 Apr 2010 11:57:53 +0200
Message-ID: <87bpdm9x0e.fsf@basil.nowhere.org>
References: <1271201355-9346-1-git-send-email-yehuda@hq.newdream.net>
	<b29a49e98a5186f83094b7a7a5dbc74647921e10.1271198630.git.yehuda@hq.newdream.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	yehudasa@gmail.com, sage@newdream.net, axboe@kernel.dk
To: Yehuda Sadeh <yehuda@hq.newdream.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <b29a49e98a5186f83094b7a7a5dbc74647921e10.1271198630.git.yehuda@hq.newdream.net> (Yehuda Sadeh's message of "Tue, 13 Apr 2010 16:29:14 -0700")
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Yehuda Sadeh <yehuda@hq.newdream.net> writes:
>  
> +int ceph_copy_to_page_vector(struct page **pages,
> +				    const char *data,
> +				    loff_t off, size_t len)
> +{
> +	int i = 0;
> +	int po = off & ~PAGE_CACHE_MASK;
> +	int left = len;
> +	int l;
> +
> +	while (left > 0) {
> +		l = min_t(int, PAGE_CACHE_SIZE-po, left);

int seems like exactly the wrong type here.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.