linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Chung-Chiang Cheng <shepjeng@gmail.com>
Cc: Chung-Chiang Cheng <cccheng@synology.com>,
	linux-fsdevel@vger.kernel.org, kernel@cccheng.net
Subject: Re: [PATCH v2 2/3] fat: make ctime and mtime identical explicitly
Date: Tue, 12 Apr 2022 18:45:36 +0900	[thread overview]
Message-ID: <87czhm4ou7.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <CAHuHWtmYdRzh=4_ou_u=KdpQi8nSr0=XKX4JLaq+=jCaN_47cA@mail.gmail.com> (Chung-Chiang Cheng's message of "Tue, 12 Apr 2022 17:23:35 +0800")

Chung-Chiang Cheng <shepjeng@gmail.com> writes:

> On Sun, Apr 10, 2022 at 11:43 PM OGAWA Hirofumi
> <hirofumi@mail.parknet.co.jp> wrote:
>>
>> Hm, this changes mtime includes ctime update. So, the question is, this
>> behavior is compatible with Windows's fatfs behavior? E.g. Windows
>> updates mtime on rename?
>>
>> If not same behavior with Windows, new behavior is new incompatible
>> behavior, and looks break fundamental purpose of this.
>>
>> I was thinking, we ignores ctime update (because fatfs doesn't have) and
>> always same with mtime. What behavior was actually compatible with
>> Windows?
>>
>
> If possible, to ignore ctime update may be a better choice that doesn't
> affect mtime. But we need an initial value for ctime when the inode is
> loaded.
>
> One possible option is to use mtime. Although ctime won't be updated
> anymore, when mtime is changed, ctime needs to take effect. Otherwise
> the next time the inode is loaded, ctime will be inconsistent. That is,
> ctime is still updated indirectly by mtime. It seems impossible to avoid
> updating ctime, or do we just show ctime a non-sense value?

I mean I also think the behavior what you said sounds like reasonable.
mtime change affect to ctime, but ctime change doesn't affect to mtime.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2022-04-12 10:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  8:54 [PATCH v2 1/3] fat: split fat_truncate_time() into separate functions Chung-Chiang Cheng
2022-04-06  8:54 ` [PATCH v2 2/3] fat: make ctime and mtime identical explicitly Chung-Chiang Cheng
2022-04-10 15:43   ` OGAWA Hirofumi
2022-04-12  9:23     ` Chung-Chiang Cheng
2022-04-12  9:45       ` OGAWA Hirofumi [this message]
2022-04-06  8:54 ` [PATCH v2 3/3] fat: report creation time in statx Chung-Chiang Cheng
2022-04-10 16:30   ` OGAWA Hirofumi
2022-04-12  9:55     ` Chung-Chiang Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czhm4ou7.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=cccheng@synology.com \
    --cc=kernel@cccheng.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=shepjeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).