From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: victor.vde@gmail.com, util-linux@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
linuxram@us.ibm.com
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Victor van den Elzen <victor.vde@gmail.com>,
"Eugene J. Markow" <ejmarkow@yahoo.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] libmount misparses mountinfo on Linux v2.6.39-rc1
Date: Fri, 01 Apr 2011 13:16:23 +0530 [thread overview]
Message-ID: <87d3l62z3k.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <19860.58082.277944.875401@gargle.gargle.HOWL>
On Thu, 31 Mar 2011 22:24:01 +0200, victor.vde@gmail.com wrote:
> /proc/self/mountinfo on Linux v2.6.39-rc1 includes the UUID of ext4
> and ext3 mounts, for example:
>
> 15 1 8:3 / / rw,noatime uuid:c645234d-9756-4d84-825e-6fe999252a34 - ext4 /dev/sda3 rw,user_xattr,acl,barrier=1,data=ordered
>
> It seems the hyphens in the uuid confuse the parser
> mnt_parse_mountinfo_line in tab_parse.c of libmount in util-linux.
shouldn't the parser look for " " followed by "-" followed by " " as the
field seperator ?
I am adding Miklos and Ram Pai to CC to check whether the kernel or the libmount
should be fixed ?
>
> My util-linux version is 2.19-4 Arch Linux.
>
> ~ $ findmnt -l /
> TARGET SOURCE FSTYPE OPTIONS
> / - 9756-4d84-825e-6fe999252a34 rw,noatime,ext4
>
> For reference, the commits in Linus' tree that introduced these uuids
> are:
>
> 93f1c20bc8cdb757be50566eff88d65c3b26881f vfs: Export file system uuid via /proc/<pid>/mountinfo
> 03cb5f03dcb26846fcad345d8c15aae91579a53d ext3: Copy fs UUID to superblock.
> f2fa2ffc2046fdc35f96366d1ec8675f4d578522 ext4: Copy fs UUID to superblock
-aneesh
next parent reply other threads:[~2011-04-01 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19860.58082.277944.875401@gargle.gargle.HOWL>
2011-04-01 7:46 ` Aneesh Kumar K. V [this message]
2011-04-01 8:45 ` [BUG] libmount misparses mountinfo on Linux v2.6.39-rc1 Miklos Szeredi
2011-04-01 9:32 ` Karel Zak
[not found] ` <20110401093240.GA11012-sHeGUpI7y9L/9pzu0YdTqQ@public.gmane.org>
2011-04-01 10:12 ` Miklos Szeredi
2011-04-01 10:38 ` Karel Zak
2011-04-05 12:23 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3l62z3k.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=ejmarkow@yahoo.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=miklos@szeredi.hu \
--cc=util-linux@vger.kernel.org \
--cc=victor.vde@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).