From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K. V" Subject: Re: [BUG] libmount misparses mountinfo on Linux v2.6.39-rc1 Date: Fri, 01 Apr 2011 13:16:23 +0530 Message-ID: <87d3l62z3k.fsf@linux.vnet.ibm.com> References: <19860.58082.277944.875401@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Viro , Victor van den Elzen , "Eugene J. Markow" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: victor.vde@gmail.com, util-linux@vger.kernel.org, Miklos Szeredi , linuxram@us.ibm.com Return-path: In-Reply-To: <19860.58082.277944.875401@gargle.gargle.HOWL> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 31 Mar 2011 22:24:01 +0200, victor.vde@gmail.com wrote: > /proc/self/mountinfo on Linux v2.6.39-rc1 includes the UUID of ext4 > and ext3 mounts, for example: > > 15 1 8:3 / / rw,noatime uuid:c645234d-9756-4d84-825e-6fe999252a34 - ext4 /dev/sda3 rw,user_xattr,acl,barrier=1,data=ordered > > It seems the hyphens in the uuid confuse the parser > mnt_parse_mountinfo_line in tab_parse.c of libmount in util-linux. shouldn't the parser look for " " followed by "-" followed by " " as the field seperator ? I am adding Miklos and Ram Pai to CC to check whether the kernel or the libmount should be fixed ? > > My util-linux version is 2.19-4 Arch Linux. > > ~ $ findmnt -l / > TARGET SOURCE FSTYPE OPTIONS > / - 9756-4d84-825e-6fe999252a34 rw,noatime,ext4 > > For reference, the commits in Linus' tree that introduced these uuids > are: > > 93f1c20bc8cdb757be50566eff88d65c3b26881f vfs: Export file system uuid via /proc//mountinfo > 03cb5f03dcb26846fcad345d8c15aae91579a53d ext3: Copy fs UUID to superblock. > f2fa2ffc2046fdc35f96366d1ec8675f4d578522 ext4: Copy fs UUID to superblock -aneesh