From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 4/8] dquot: cleanup dquot transfer routine Date: Mon, 01 Mar 2010 14:20:19 +0300 Message-ID: <87d3zo8f0s.fsf@openvz.org> References: <20100220115101.469826792@bombadil.infradead.org> <20100220115213.269522934@bombadil.infradead.org> <20100224231413.GE3097@quack.suse.cz> <20100301095052.GA2869@infradead.org> <20100301104052.GA3271@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from mail-bw0-f209.google.com ([209.85.218.209]:51483 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751071Ab0CALUY (ORCPT ); Mon, 1 Mar 2010 06:20:24 -0500 Received: by bwz1 with SMTP id 1so269243bwz.21 for ; Mon, 01 Mar 2010 03:20:22 -0800 (PST) In-Reply-To: <20100301104052.GA3271@quack.suse.cz> (Jan Kara's message of "Mon, 1 Mar 2010 11:40:53 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jan Kara writes: > On Mon 01-03-10 04:50:52, Christoph Hellwig wrote: >> On Thu, Feb 25, 2010 at 12:14:14AM +0100, Jan Kara wrote: >> > On Sat 20-02-10 06:51:05, Christoph Hellwig wrote: >> > > Get rid of the transfer dquot operation - it is now always called from >> > > the filesystem and if a filesystem really needs it's own (which none >> > > currently does) it can just call into it's own routine directly. >> > > >> > > Rename the now static low-level dquot_transfer helper to __dquot_transfer >> > > and vfs_dq_transfer to dquot_transfer to have a consistent namespace, >> > > and make the new dquot_transfer return a normal negative errno value >> > > which all callers expect. >> > Looks good. I just wonder - if you made dquot_transfer() return error >> > code, shouldn't also dquot_alloc_inode, dquot_alloc_space and similar >> > return error code instead of 1? It would seem more consistent. >> >> Probably - I can do that in another pass if you haven't done it yet. > I've already done it. See commits > 3a3d2903d3e9aaba9ca154606cf2f2613839b079 and > bff3333e868578990f6fe794a7cba0c74bd433ac in my linux-fs-2.6 tree. I can't find it, in what branch this commits belong? May be i've pulled it in wrong way, but i cant find it in web fron-end too. Can you please provide a web link > > Honza