From: Dmitry Monakhov <dmonakhov@openvz.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH 4/4] quota: add generic subtree quota support
Date: Tue, 16 Feb 2010 11:25:28 +0300 [thread overview]
Message-ID: <87d405vb7r.fsf@openvz.org> (raw)
In-Reply-To: <20100216081426.GA2622@infradead.org> (Christoph Hellwig's message of "Tue, 16 Feb 2010 03:14:26 -0500")
Christoph Hellwig <hch@infradead.org> writes:
> On Tue, Feb 16, 2010 at 08:31:52AM +0300, Dmitry Monakhov wrote:
>> After this patch it is possible to implement fs-speciffic
>> subtree quota part.
>>
>> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>> ---
>> fs/quota/dquot.c | 5 +++++
>> fs/quota/quotaio_v2.h | 6 ++++--
>> include/linux/quota.h | 6 ++++--
>> 3 files changed, 13 insertions(+), 4 deletions(-)
>
> Please call this project quota, and instead of introducing the get_id
> callback make it entirely generic. There's no point in adding artifical
> differences just at the point where I'm doing the long overdue
> consolidation of the XFS quota support and the "VFS" quote bits.
But this is not "project quota". Project quota is XFS feature.
This patch aimed to give an opportunity to implement fs-specific
quota_id mapping, and XFS is just an one of possible usecases.
next prev parent reply other threads:[~2010-02-16 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 5:31 [PATCH 0/4] quota: RFC add extend quota type v2 Dmitry Monakhov
2010-02-16 5:31 ` [PATCH 1/4] quota: sb_quota state flags cleanup Dmitry Monakhov
2010-02-16 5:31 ` [PATCH 2/4] quota: generalize quota transfer interface Dmitry Monakhov
2010-02-16 5:31 ` [PATCH 3/4] introduce get_id callback Dmitry Monakhov
2010-02-16 5:31 ` [PATCH 4/4] quota: add generic subtree quota support Dmitry Monakhov
2010-02-16 8:14 ` Christoph Hellwig
2010-02-16 8:25 ` Dmitry Monakhov [this message]
2010-02-16 8:28 ` Christoph Hellwig
2010-02-16 8:56 ` Dmitry Monakhov
2010-02-16 9:03 ` Christoph Hellwig
2010-02-16 21:13 ` [PATCH 0/4] quota: RFC add extend quota type v2 Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d405vb7r.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).