From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 4/4] quota: add generic subtree quota support Date: Tue, 16 Feb 2010 11:25:28 +0300 Message-ID: <87d405vb7r.fsf@openvz.org> References: <1266298312-25885-1-git-send-email-dmonakhov@openvz.org> <1266298312-25885-2-git-send-email-dmonakhov@openvz.org> <1266298312-25885-3-git-send-email-dmonakhov@openvz.org> <1266298312-25885-4-git-send-email-dmonakhov@openvz.org> <1266298312-25885-5-git-send-email-dmonakhov@openvz.org> <20100216081426.GA2622@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz To: Christoph Hellwig Return-path: Received: from mail-bw0-f213.google.com ([209.85.218.213]:41438 "EHLO mail-bw0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753133Ab0BPIZd (ORCPT ); Tue, 16 Feb 2010 03:25:33 -0500 Received: by bwz5 with SMTP id 5so1689330bwz.1 for ; Tue, 16 Feb 2010 00:25:31 -0800 (PST) In-Reply-To: <20100216081426.GA2622@infradead.org> (Christoph Hellwig's message of "Tue, 16 Feb 2010 03:14:26 -0500") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Christoph Hellwig writes: > On Tue, Feb 16, 2010 at 08:31:52AM +0300, Dmitry Monakhov wrote: >> After this patch it is possible to implement fs-speciffic >> subtree quota part. >> >> Signed-off-by: Dmitry Monakhov >> --- >> fs/quota/dquot.c | 5 +++++ >> fs/quota/quotaio_v2.h | 6 ++++-- >> include/linux/quota.h | 6 ++++-- >> 3 files changed, 13 insertions(+), 4 deletions(-) > > Please call this project quota, and instead of introducing the get_id > callback make it entirely generic. There's no point in adding artifical > differences just at the point where I'm doing the long overdue > consolidation of the XFS quota support and the "VFS" quote bits. But this is not "project quota". Project quota is XFS feature. This patch aimed to give an opportunity to implement fs-specific quota_id mapping, and XFS is just an one of possible usecases.