From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out01.mta.xmission.com ([166.70.13.231]:40007 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728163AbeK2ElS (ORCPT ); Wed, 28 Nov 2018 23:41:18 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Ondrej Mosnacek Cc: Paul Moore , selinux@vger.kernel.org, Trond Myklebust , Seth Forshee , linux-fsdevel@vger.kernel.org, Linux Security Module list References: <20181116131202.26513-1-omosnace@redhat.com> <87r2f5fbw7.fsf@xmission.com> Date: Wed, 28 Nov 2018 11:38:39 -0600 In-Reply-To: (Ondrej Mosnacek's message of "Wed, 28 Nov 2018 17:12:00 +0100") Message-ID: <87efb5f6g0.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [PATCH] selinux: always allow mounting submounts Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Ondrej Mosnacek writes: > On Wed, Nov 28, 2018 at 4:42 PM Eric W. Biederman wrote: >> >> A few late comments on this. >> >> The change mentioned in fixes did not remove a SB_KERNMOUNT so I don't >> see how it is a fix for that. That change just added SB_SUBMOUNT so you >> can test for and detect this situation. Are you seeing something that I >> am not in that change? > > No, you're right that this patch doesn't "fix" that commit in the > usual sense (the bug has pretty much always been there). However, that > commit is the one that introduces the SB_KERNMOUNT flag and thus this > patch can be only applied on trees that have that commit. That's what > I tried to communicate with the "Fixes:" tag. Maybe I abused it a > little, but it is often used to guide backporting so I figured it > would make sense like this. That makes sense. In cases like that I use Ref: instead of Fixes: That makes the connection clear, without implying the other patch was wrong. That and I would say something like. It is now possible to fix this as submounts are not detectable. Or something like that. Eric