From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>,
"J. Bruce Fields" <bfields@fieldses.org>
Cc: agruen@kernel.org, akpm@linux-foundation.org,
viro@zeniv.linux.org.uk, dhowells@redhat.com,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -V8 00/26] New ACL format for better NFSv4 acl interoperability
Date: Mon, 24 Oct 2011 17:05:28 +0530 [thread overview]
Message-ID: <87fwiiei67.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20111024094910.GA28693@infradead.org>
On Mon, 24 Oct 2011 05:49:10 -0400, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Oct 24, 2011 at 05:17:16AM -0400, J. Bruce Fields wrote:
> > > How do we push these changes to Linus tree ? Andrew, Viro, any comment
> > > on how we can get this merged upstream ?
> >
> > Andrew, it sounds like you might be willing to shepherd these through?
> > Let us know what you'd need.
>
> It really has to through the VFS tree. And to be honest despite the
> repostings there's been exactly zero progress on getting there.
>
> Please as a first thing submit the various small cleanups indepent
> of the other changes. If you can't even those in there's no point
> in trying.
I will do this as the next step. The series actually contain them as
separate patches.
> Second do not repeat the mistakes of the old ACL code,
> that is don't do too much work inside the filesystems. Al, Linus
> and me spent a lot of working on pushing it into common code and
> it's not done. For any new ACL model I really want to see zero
> per-fs code except for callouts in chmod & co and actually
> setting the xattr vector to a genericly provided one. And please
> wire up all common filesystems to actually prove that point.
>
This is what is done currently. I have only hooked up ext4 though.
What I have done is add a new inode operation get_richacl, that
returns struct richacl *. Are you suggesting to get rid of that
and make sure get_acl can return different type of ACL based on
argument passed ?. IMHO that would end up making the code more complex.
> I also really hate all the duplication - I want to see a really good
> reason why all this code needs to be duplicated. Just look at
> the mess done to check_acl and the ACL caching in the inode and
> any normal person would throw up. There is absolutely no reason
> to not implement Posix ACLs as a subset of the NFSv4 ACL (not actually
> a subset in the strict mathematical sense, but close enough).
>
Can you explain this more ? What you would like to see changed ?
> After all this techical work (which was brought up before) has been
> done you can resubmit it. And that point you'd better have very
> good and very lengthy rationale for why adding an utterly stupid
> ACL model is supposed to be a good idea.
Thanks for the feedback.
-aneesh
prev parent reply other threads:[~2011-10-24 11:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-23 17:43 [PATCH -V8 00/26] New ACL format for better NFSv4 acl interoperability Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 01/26] vfs: Indicate that the permission functions take all the MAY_* flags Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 02/26] vfs: Add hex format for MAY_* flag values Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 03/26] vfs: Pass all mask flags down to iop->check_acl Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 04/26] vfs: Add a comment to inode_permission() Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 05/26] vfs: Add generic IS_ACL() test for acl support Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 06/26] vfs: Add IS_RICHACL() test for richacl support Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 07/26] vfs: Optimize out IS_RICHACL() if CONFIG_FS_RICHACL is not defined Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 08/26] vfs: Add new file and directory create permission flags Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 09/26] vfs: Add delete child and delete self " Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 10/26] vfs: Make the inode passed to inode_change_ok non-const Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 11/26] vfs: Add permission flags for setting file attributes Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 12/26] vfs: Make acl_permission_check() work for richacls Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 13/26] richacl: In-memory representation and helper functions Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 14/26] richacl: Permission mapping functions Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 15/26] richacl: Compute maximum file masks from an acl Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 16/26] richacl: Update the file masks in chmod() Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 17/26] richacl: Permission check algorithm Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 18/26] richacl: Create-time inheritance Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 19/26] richacl: Check if an acl is equivalent to a file mode Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 20/26] richacl: Automatic Inheritance Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 21/26] richacl: xattr mapping functions Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 22/26] vfs: Cache richacl in struct inode Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 23/26] vfs: Add richacl permission check Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 24/26] ext4: Use IS_POSIXACL() to check for POSIX ACL support Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 25/26] ext4: Implement rich acl for ext4 Aneesh Kumar K.V
2011-10-23 17:43 ` [PATCH -V8 26/26] ext4: Add Ext4 compat richacl feature flag Aneesh Kumar K.V
[not found] ` <1319391835-5829-1-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2011-10-24 9:17 ` [PATCH -V8 00/26] New ACL format for better NFSv4 acl interoperability J. Bruce Fields
[not found] ` <20111024091716.GA1109-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2011-10-24 9:49 ` Christoph Hellwig
[not found] ` <20111024094910.GA28693-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-10-24 11:07 ` J. Bruce Fields
[not found] ` <20111024110759.GA1863-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2011-10-25 13:30 ` J. Bruce Fields
2011-10-24 11:35 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwiiei67.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=agruen@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).