From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH -V6 09/26] vfs: Add delete child and delete self permission flags Date: Fri, 09 Sep 2011 17:25:34 +0530 Message-ID: <87fwk63p6x.fsf@skywalker.in.ibm.com> References: <1315243548-18664-10-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1315243548-18664-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <22928.1315563126@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, agruen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Howells Return-path: In-Reply-To: <22928.1315563126-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 09 Sep 2011 11:12:06 +0100, David Howells wrote: > Aneesh Kumar K.V wrote: > > > + if ((error || is_sticky) && IS_RICHACL(inode) && > > + !inode_permission(dir, mask & ~(MAY_WRITE | MAY_DELETE_CHILD)) && > > + !inode_permission(inode, MAY_DELETE_SELF)) > > + error = 0; > > This might be easier to follow if you used == 0 rather than !. The problem > with ! is that it looks like: > > not_have inode_permission. > > I guess this is just one of the fun consequences of having 0 (false) meaning > okay. > Updated to do == 0 check -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html