From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH -V6 10/26] vfs: Make the inode passed to inode_change_ok non-const Date: Thu, 08 Sep 2011 15:02:15 +0530 Message-ID: <87fwk75qhs.fsf@skywalker.in.ibm.com> References: <1315243548-18664-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1315243548-18664-11-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20110907204321.GF8074@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: agruen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "J. Bruce Fields" Return-path: In-Reply-To: <20110907204321.GF8074-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 7 Sep 2011 16:43:22 -0400, "J. Bruce Fields" wrote: > On Mon, Sep 05, 2011 at 10:55:32PM +0530, Aneesh Kumar K.V wrote: > > From: Andreas Gruenbacher > > > > We will need to call iop->permission and iop->get_acl from > > inode_change_ok() for additional permission checks, and both take a > > non-const inode. > > OK, the essential difference being that richacls have a say in whether > we can change attributes or not, which posix acls (for example) don't? > yes, next patch explain the details of the check -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html