public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luis Henriques <luis@igalia.com>
To: Horst Birthelmer <horst@birthelmer.de>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	 Amir Goldstein <amir73il@gmail.com>,
	 Bernd Schubert <bschubert@ddn.com>,
	 Bernd Schubert <bernd@bsbernd.com>,
	 "Darrick J. Wong" <djwong@kernel.org>,
	 Horst Birthelmer <hbirthelmer@ddn.com>,
	 Joanne Koong <joannelkoong@gmail.com>,
	Kevin Chen <kchen@ddn.com>,
	 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Matt Harvey <mharvey@jumptrading.com>,
	kernel-dev@igalia.com
Subject: Re: [RFC PATCH v3 0/8] fuse: LOOKUP_HANDLE operation
Date: Wed, 25 Feb 2026 17:06:08 +0000	[thread overview]
Message-ID: <87h5r469dr.fsf@wotan.olymp> (raw)
In-Reply-To: <aZ8RJFhnYA0519sv@fedora.fritz.box> (Horst Birthelmer's message of "Wed, 25 Feb 2026 16:14:56 +0100")

Hey Horst,

On Wed, Feb 25 2026, Horst Birthelmer wrote:

> On Wed, Feb 25, 2026 at 11:24:31AM +0000, Luis Henriques wrote:
>> Hi,
>> 
>> I'm sending a new version of my work on lookup_handle, even though it's
>> still incomplete.  As suggested elsewhere, it is now based on compound
>> commands and thus it sits on top of Horst's patchset [0].  Also, because
>> this version is a complete re-write of the approach presented in my previous
>> RFC [1] I'm not going to detail what changed.
>> 
>> Here's a few notes:
>> 
>> - The code isn't yet fully testable as there are several pieces missing.
>>   For example, the FUSE_TMPFILE and FUSE_READDIRPLUS operations are not yet
>>   implemented.  The NFS-related changes have also been dropped in this
>>   revision.
>> 
>> - There are several details still to be sorted out in the compound
>>   operations.  For example, the nodeid for the statx operation in the
>>   lookup+statx is set to FUSE_ROOT_ID.
>> 
>> - The second operation (mkobj_handle+statx+open) is still draft (or maybe
>>   just wrong!).  It's not handling flags correctly, and the error handling
>>   has to be better thought out.
>> 
>> - Some of the patches in this set could probably be picked independently
>>   (e.g. patch 4 or even patch 1)
>> 
>> So, why am I sending this broken and incomplete patchset?  Well, simply
>> because I'd feel more confidence getting this approach validated.  I don't
>> expect any through review, but I would appreciate feedback on anything that
>> would help me correct major flaws.
>
> I, personally, appreciate the fact that you sent this out, so I can understand how
> you are using the compounds for this real world problem, and it gives me confidence
> that I'm not completely off with the compounds. 
>
> Do you by any chance have implemented the fuse server part, too, or looked at it?
> I'm just curious.

I do have _something_ for testing, yes.  Obviously, I will eventually
share it but I wasn't planning to share it at this stage yet (it's ugly
and full of debug code).  But if you'd like to have a look I can do a quick
clean-up and push it somewhere.

Cheers,
-- 
Luís

      reply	other threads:[~2026-02-25 17:06 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 11:24 [RFC PATCH v3 0/8] fuse: LOOKUP_HANDLE operation Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 1/8] fuse: simplify fuse_lookup_name() interface Luis Henriques
2026-02-27 15:46   ` Miklos Szeredi
2026-02-28 14:42     ` Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 2/8] fuse: export extend_arg() and factor out fuse_ext_size() Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 3/8] fuse: store index of the variable length argument Luis Henriques
2026-02-27 15:41   ` Miklos Szeredi
2026-02-28 14:50     ` Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 4/8] fuse: drop unnecessary argument from fuse_lookup_init() Luis Henriques
2026-02-27 15:57   ` Miklos Szeredi
2026-02-25 11:24 ` [RFC PATCH v3 5/8] fuse: extract helper functions from fuse_do_statx() Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 6/8] fuse: implementation of lookup_handle+statx compound operation Luis Henriques
2026-02-25 18:06   ` Amir Goldstein
2026-02-26  9:54     ` Luis Henriques
2026-02-26 10:08       ` Amir Goldstein
2026-02-26 10:29         ` Miklos Szeredi
2026-02-26 15:06           ` Luis Henriques
2026-02-26 15:44             ` Miklos Szeredi
2026-02-26 16:17               ` Luis Henriques
2026-02-26 10:33         ` Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 7/8] fuse: export fuse_open_args_fill() helper function Luis Henriques
2026-02-25 11:24 ` [RFC PATCH v3 8/8] fuse: implementation of mkobj_handle+statx+open compound operation Luis Henriques
2026-02-25 15:08   ` Horst Birthelmer
2026-02-25 17:26     ` Luis Henriques
2026-02-25 15:14 ` [RFC PATCH v3 0/8] fuse: LOOKUP_HANDLE operation Horst Birthelmer
2026-02-25 17:06   ` Luis Henriques [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5r469dr.fsf@wotan.olymp \
    --to=luis@igalia.com \
    --cc=amir73il@gmail.com \
    --cc=bernd@bsbernd.com \
    --cc=bschubert@ddn.com \
    --cc=djwong@kernel.org \
    --cc=hbirthelmer@ddn.com \
    --cc=horst@birthelmer.de \
    --cc=joannelkoong@gmail.com \
    --cc=kchen@ddn.com \
    --cc=kernel-dev@igalia.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mharvey@jumptrading.com \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox