From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 468A5C433EF for ; Tue, 8 Mar 2022 19:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350008AbiCHTgd (ORCPT ); Tue, 8 Mar 2022 14:36:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349999AbiCHTgc (ORCPT ); Tue, 8 Mar 2022 14:36:32 -0500 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DC7454688; Tue, 8 Mar 2022 11:35:35 -0800 (PST) Received: from in02.mta.xmission.com ([166.70.13.52]:60392) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nRfcL-006Rk2-Nb; Tue, 08 Mar 2022 12:35:33 -0700 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:33848 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nRfcK-001fpg-Bz; Tue, 08 Mar 2022 12:35:33 -0700 From: "Eric W. Biederman" To: Kees Cook Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , Denys Vlasenko , Vlastimil Babka , "Liam R . Howlett" , Jann Horn , References: <20220131153740.2396974-1-willy@infradead.org> <871r0nriy4.fsf@email.froward.int.ebiederm.org> <877dafq3bw.fsf@email.froward.int.ebiederm.org> <87bkzroica.fsf_-_@email.froward.int.ebiederm.org> Date: Tue, 08 Mar 2022 13:35:03 -0600 In-Reply-To: <87bkzroica.fsf_-_@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Mon, 31 Jan 2022 12:44:53 -0600") Message-ID: <87h788fdaw.fsf_-_@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nRfcK-001fpg-Bz;;;mid=<87h788fdaw.fsf_-_@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18VHZi4qAUqp2lFjUGTMEwqPtkpQK8w5+o= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: [GIT PULL] Fix fill_files_note X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Kees, Please pull the coredump-vma-snapshot-fix branch from the git tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git coredump-vma-snapshot-fix HEAD: 390031c942116d4733310f0684beb8db19885fe6 coredump: Use the vma snapshot in fill_files_note Matthew Wilcox has reported that a missing mmap_lock in file_files_note, which could cause trouble. Refactor the code and clean it up so that the vma snapshot makes it to fill_files_note, and then use the vma snapshot in fill_files_note. Eric W. Biederman (5): coredump: Move definition of struct coredump_params into coredump.h coredump: Snapshot the vmas in do_coredump coredump: Remove the WARN_ON in dump_vma_snapshot coredump/elf: Pass coredump_params into fill_note_info coredump: Use the vma snapshot in fill_files_note fs/binfmt_elf.c | 66 ++++++++++++++++++++++-------------------------- fs/binfmt_elf_fdpic.c | 18 +++++-------- fs/binfmt_flat.c | 1 + fs/coredump.c | 59 ++++++++++++++++++++++++++++--------------- include/linux/binfmts.h | 13 +--------- include/linux/coredump.h | 20 ++++++++++++--- 6 files changed, 93 insertions(+), 84 deletions(-) --- Kees I realized I needed to rebase this on Jann Horn's commit 84158b7f6a06 ("coredump: Also dump first pages of non-executable ELF libraries"). Unfortunately before I got that done I got distracted and these changes have been sitting in limbo for most of the development cycle. Since you are running a tree that is including changes like this including Jann's can you please pull these changes into your tree. Thank you, Eric