From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [patch 05/10] fs: remove extra lookup in __lookup_hash Date: Wed, 18 Aug 2010 15:57:10 +0200 Message-ID: <87iq38koqx.fsf@basil.nowhere.org> References: <20100817183729.613117146@kernel.dk> <20100817184121.115628228@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from one.firstfloor.org ([213.235.205.2]:51968 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753239Ab0HRN5M (ORCPT ); Wed, 18 Aug 2010 09:57:12 -0400 In-Reply-To: <20100817184121.115628228@kernel.dk> (Nick Piggin's message of "Wed, 18 Aug 2010 04:37:34 +1000") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Nick Piggin writes: > - Delete some boring legacy comments because we don't care much about how the > code used to work, more about the interesting parts of how it works now. So > comments about lazy LRU may be interesting, but would better be done in the > LRU or refcount management code. It would have been nice if you had done all the comment changes in another patch. As far as I can see this is only a two liner and it looks obviously correct. As a quick experiment I set a systemtap probe for this on my workstation global first, second probe kernel.function("*@fs/namei.c:1143") { first++ } probe kernel.function("*@fs/namei.c:1149") { second++ } probe end { printf("first %d, second %d\n", first, second) } and did a quick kernel build, resulting in: first 22753, second 22753 So yes it looks like the hit rate is about zero for the first case and the change is good. Reviewed-by: Andi Kleen -Andi -- ak@linux.intel.com -- Speaking for myself only.