From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH 0/9] overlay filesystem: request for inclusion (v17) Date: Wed, 13 Mar 2013 12:54:51 -0700 Message-ID: <87k3pbhy7o.fsf@xmission.com> References: <1363184193-1796-1-git-send-email-miklos@szeredi.hu> <20130313181251.GA6023@sgi.com> <5140C77E.7030206@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain Cc: Felix Fietkau , Robin Holt , Miklos Szeredi , viro@zeniv.linux.org.uk, torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org, apw@canonical.com, neilb@suse.de, jordipujolp@gmail.com, ezk@fsl.cs.sunysb.edu, dhowells@redhat.com, sedat.dilek@googlemail.com, hooanon05@yahoo.co.jp, mszeredi@suse.cz To: sedat.dilek@gmail.com Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:47099 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932236Ab3CMTzK (ORCPT ); Wed, 13 Mar 2013 15:55:10 -0400 In-Reply-To: (Sedat Dilek's message of "Wed, 13 Mar 2013 20:10:25 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Sedat Dilek writes: > On Wed, Mar 13, 2013 at 7:37 PM, Felix Fietkau wrote: >> On 2013-03-13 7:12 PM, Robin Holt wrote: >>> On Wed, Mar 13, 2013 at 05:51:33PM +0100, Sedat Dilek wrote: >>>> On Wed, Mar 13, 2013 at 5:21 PM, Miklos Szeredi wrote: >>>> > On Wed, Mar 13, 2013 at 5:10 PM, Sedat Dilek wrote: >>>> > >>>> >> Anyway, with CONFIG_OVERLAYFS_FS=m I do not see any related messages >>>> >> when the kernel-module is loaded. >>>> >> So, is this intended? >>>> >> SquashFS prints into the logs, so what is it doing differently? >>>> > >>>> > Some modules do, some don't. It's not compulsory and not very useful. >>>> > >>>> >>>> What about... >>>> >>>> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c >>>> index 482c26f..92b9ad5 100644 >>>> --- a/fs/overlayfs/super.c >>>> +++ b/fs/overlayfs/super.c >>>> @@ -675,11 +675,13 @@ MODULE_ALIAS_FS("overlayfs"); >>>> static int __init ovl_init(void) >>>> { >>>> return register_filesystem(&ovl_fs_type); >>>> + printk(KERN_INFO "overlayfs: loaded\n"); >>> >>> How about pr_debug(). That makes things quite for most of us but gives >>> you info when looking for things like boot problems. >> How is having a printk/pr_debug useful here at all? The fact that other >> filesystems do this as well is not a good reason... >> Also, putting it *after* the return statement doesn't make much sense ;) >> > > Hehe, I just checked my new kernel... that does not work (nothing in the logs). > But I think it's good to see if the filesystem is registered/loaded. lsmod | grep overlayfs Eric