From: Gabriel Krisman Bertazi <gabriel@krisman.be>
To: Joseph Salisbury <joseph.salisbury@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unicode: utf8-norm: fix comment typo
Date: Mon, 23 Mar 2026 11:31:54 -0400 [thread overview]
Message-ID: <87ldfisgt1.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <20260316184935.163597-1-joseph.salisbury@oracle.com> (Joseph Salisbury's message of "Mon, 16 Mar 2026 14:49:35 -0400")
Joseph Salisbury <joseph.salisbury@oracle.com> writes:
> The file contains a spelling error in a source comment (succes).
>
> Typos in comments reduce readability and make text searches less reliable
> for developers and maintainers.
>
> Replace 'succes' with 'success' in the affected comment. This is a
> comment-only cleanup and does not change behavior.
These typo-only fixes are way more of an annoyance when backporting real
fixes than adding any real value. Somehow I doubt fixing a single typo
makes the code more readable.
But at least, can you make this a single patch with all the fixes to
fs/unicode/ instead of one patch per typo?
> Fixes: 44594c2fbf42 ("unicode: introduce code for UTF-8 normalization")
> Cc: stable@vger.kernel.org
Please remove this.
> Signed-off-by: Joseph Salisbury <joseph.salisbury@oracle.com>
> ---
> fs/unicode/utf8-norm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
> index 7b998c99c88d..41e884569dbe 100644
> --- a/fs/unicode/utf8-norm.c
> +++ b/fs/unicode/utf8-norm.c
> @@ -444,7 +444,7 @@ int utf8ncursor(struct utf8cursor *u8c, const struct unicode_map *um,
> /*
> * Get one byte from the normalized form of the string described by u8c.
> *
> - * Returns the byte cast to an unsigned char on succes, and -1 on failure.
> + * Returns the byte cast to an unsigned char on success, and -1 on failure.
> *
> * The cursor keeps track of the location in the string in u8c->s.
> * When a character is decomposed, the current location is stored in
--
Gabriel Krisman Bertazi
prev parent reply other threads:[~2026-03-23 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 18:49 [PATCH] unicode: utf8-norm: fix comment typo Joseph Salisbury
2026-03-16 23:49 ` [External] : " Joseph Salisbury
2026-03-23 15:31 ` Gabriel Krisman Bertazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ldfisgt1.fsf@mailhost.krisman.be \
--to=gabriel@krisman.be \
--cc=joseph.salisbury@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox