From: Dmitry Monakhov <dmonakhov@openvz.org>
To: Brad Boyer <flar@allandria.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/6] vfs: add per-sb auxiliary inode attribute table
Date: Thu, 18 Feb 2010 22:34:51 +0300 [thread overview]
Message-ID: <87mxz62v8k.fsf@openvz.org> (raw)
In-Reply-To: <20100218190022.GA1783@cynthia.pants.nu> (Brad Boyer's message of "Thu, 18 Feb 2010 11:00:22 -0800")
Brad Boyer <flar@allandria.com> writes:
> On Thu, Feb 18, 2010 at 07:45:25PM +0300, Dmitry Monakhov wrote:
>> Some times it is useful to export non standard attributes
>> to generic vfs layer, but it is too expansive to store it
>> inside vfs inode. Let's introduce generic interface for this
>> purpose. One may declare an attribute and filesystem provides
>> access to it, if necessery.
>>
>> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>> ---
>> @@ -1576,7 +1578,10 @@ struct super_operations {
>> #endif
>> int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t);
>> };
>> -
>> +struct aux_attributes
>> +{
>> + int supported;
>> +};
>> /*
>> * Inode state bits. Protected by inode_lock.
>> *
>> --
>
> What is the intended use of the supported field? You don't appear to use
> it anywhere other than to initialize it to 1 in the one instance where
> you create one of them.
Actually i've use this only as a place holder, otherwise structure
will be empty.
>
> Brad Boyer
> flar@allandria.com
next prev parent reply other threads:[~2010-02-18 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:45 [PATCH 0/6] RFC: introduce extended inode owner identifier v4 Dmitry Monakhov
2010-02-18 16:45 ` [PATCH 1/6] vfs: add per-sb auxiliary inode attribute table Dmitry Monakhov
2010-02-18 16:45 ` [PATCH 2/6] quota: switch reservation space management to aux_attribute Dmitry Monakhov
2010-02-18 16:45 ` [PATCH 3/6] vfs: Add additional owner identifier Dmitry Monakhov
2010-02-18 16:45 ` [PATCH 4/6] quota: Implement metagroup support for quota Dmitry Monakhov
2010-02-18 16:45 ` [PATCH 5/6] ext4: enlarge mount option field Dmitry Monakhov
2010-02-18 16:45 ` [PATCH 6/6] ext4: Implement metagroup support for ext4 filesystem Dmitry Monakhov
2010-02-18 19:00 ` [PATCH 1/6] vfs: add per-sb auxiliary inode attribute table Brad Boyer
2010-02-18 19:34 ` Dmitry Monakhov [this message]
2010-02-18 23:31 ` [PATCH 0/6] RFC: introduce extended inode owner identifier v4 Dave Chinner
2010-02-19 10:16 ` Dmitry Monakhov
2010-02-19 23:31 ` Dave Chinner
2010-02-20 10:58 ` Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxz62v8k.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=flar@allandria.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).