From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 1/6] vfs: add per-sb auxiliary inode attribute table Date: Thu, 18 Feb 2010 22:34:51 +0300 Message-ID: <87mxz62v8k.fsf@openvz.org> References: <1266511530-10533-1-git-send-email-dmonakhov@openvz.org> <1266511530-10533-2-git-send-email-dmonakhov@openvz.org> <20100218190022.GA1783@cynthia.pants.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Brad Boyer Return-path: Received: from fg-out-1718.google.com ([72.14.220.155]:22551 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758055Ab0BRTe5 (ORCPT ); Thu, 18 Feb 2010 14:34:57 -0500 Received: by fg-out-1718.google.com with SMTP id 22so26236fge.1 for ; Thu, 18 Feb 2010 11:34:54 -0800 (PST) In-Reply-To: <20100218190022.GA1783@cynthia.pants.nu> (Brad Boyer's message of "Thu, 18 Feb 2010 11:00:22 -0800") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Brad Boyer writes: > On Thu, Feb 18, 2010 at 07:45:25PM +0300, Dmitry Monakhov wrote: >> Some times it is useful to export non standard attributes >> to generic vfs layer, but it is too expansive to store it >> inside vfs inode. Let's introduce generic interface for this >> purpose. One may declare an attribute and filesystem provides >> access to it, if necessery. >> >> Signed-off-by: Dmitry Monakhov >> --- >> @@ -1576,7 +1578,10 @@ struct super_operations { >> #endif >> int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t); >> }; >> - >> +struct aux_attributes >> +{ >> + int supported; >> +}; >> /* >> * Inode state bits. Protected by inode_lock. >> * >> -- > > What is the intended use of the supported field? You don't appear to use > it anywhere other than to initialize it to 1 in the one instance where > you create one of them. Actually i've use this only as a place holder, otherwise structure will be empty. > > Brad Boyer > flar@allandria.com