From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 0/9] dquot interface cleanups v2 Date: Wed, 03 Mar 2010 18:36:58 +0300 Message-ID: <87pr3lmn6t.fsf@openvz.org> References: <20100303140459.300799061@bombadil.infradead.org> <87tysxmp9r.fsf@openvz.org> <20100303145627.GE6290@quack.suse.cz> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from mail-bw0-f209.google.com ([209.85.218.209]:45403 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753184Ab0CCPhH (ORCPT ); Wed, 3 Mar 2010 10:37:07 -0500 Received: by bwz1 with SMTP id 1so15408bwz.21 for ; Wed, 03 Mar 2010 07:37:03 -0800 (PST) In-Reply-To: <20100303145627.GE6290@quack.suse.cz> (Jan Kara's message of "Wed, 3 Mar 2010 15:56:27 +0100") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-=-= Jan Kara writes: > On Wed 03-03-10 17:52:00, Dmitry Monakhov wrote: >> Christoph Hellwig writes: >> >> > Get rid of the dquot operations that were used for calls from the >> > filesystems into the dquot code, clean up the namespace for calls >> > to the dquot code to always be dquot_, and move the few calls into >> > the dquot code that were in the VFS into the filesystems. >> > >> > This version dddresses various comments from Jan and adds a new patch >> > to get rid of the QUOTA_OK / NO_QUOTA return values. >> I'm not able to apply the patch set on top of linux-fs-2.6/for_next >> and linux-fs-2.6/for_next w/o your previous patches >> Which tree/commit this patch-set is aimed to? > It replaces the old version of the series in my for_next branch... > I'll take care of that. Ok. BTW: i've able to apply the patch-set, can you please fold tiny fix below to appropriate patches. It's aimed to complete error code handling convention. This allow us later to return other than EDQUOT errors from quota code. --=-=-= Content-Type: application/octet-stream Content-Disposition: inline; filename=diff Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2ZzL2V4dDQvaW5vZGUuYyBiL2ZzL2V4dDQvaW5vZGUuYwppbmRleCAzYzc0 MDk2Li44MmIzMzUzIDEwMDY0NAotLS0gYS9mcy9leHQ0L2lub2RlLmMKKysrIGIvZnMvZXh0NC9p bm9kZS5jCkBAIC0xODM5LDcgKzE4MzksNyBAQCBzdGF0aWMgaW50IGV4dDRfZGFfcmVzZXJ2ZV9z cGFjZShzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzZWN0b3JfdCBsYmxvY2spCiAJc3RydWN0IGV4dDRf c2JfaW5mbyAqc2JpID0gRVhUNF9TQihpbm9kZS0+aV9zYik7CiAJc3RydWN0IGV4dDRfaW5vZGVf aW5mbyAqZWkgPSBFWFQ0X0koaW5vZGUpOwogCXVuc2lnbmVkIGxvbmcgbWRfbmVlZGVkLCBtZF9y ZXNlcnZlZDsKLQorCWludCByZXQ7CiAJLyoKIAkgKiByZWNhbGN1bGF0ZSB0aGUgYW1vdW50IG9m IG1ldGFkYXRhIGJsb2NrcyB0byByZXNlcnZlCiAJICogaW4gb3JkZXIgdG8gYWxsb2NhdGUgbnJi bG9ja3MKQEAgLTE4NTYsOCArMTg1Niw5IEBAIHJlcGVhdDoKIAkgKiBsYXRlci4gUmVhbCBxdW90 YSBhY2NvdW50aW5nIGlzIGRvbmUgYXQgcGFnZXMgd3JpdGVvdXQKIAkgKiB0aW1lLgogCSAqLwot CWlmIChkcXVvdF9yZXNlcnZlX2Jsb2NrKGlub2RlLCBtZF9uZWVkZWQgKyAxKSkKLQkJcmV0dXJu IC1FRFFVT1Q7CisJcmV0ID0gZHF1b3RfcmVzZXJ2ZV9ibG9jayhpbm9kZSwgbWRfbmVlZGVkICsg MSk7CisJaWYgKHJldCkKKwkJcmV0dXJuIHJldDsKIAogCWlmIChleHQ0X2NsYWltX2ZyZWVfYmxv Y2tzKHNiaSwgbWRfbmVlZGVkICsgMSkpIHsKIAkJZHF1b3RfcmVsZWFzZV9yZXNlcnZhdGlvbl9i bG9jayhpbm9kZSwgbWRfbmVlZGVkICsgMSk7CmRpZmYgLS1naXQgYS9mcy91ZGYvYmFsbG9jLmMg Yi9mcy91ZGYvYmFsbG9jLmMKaW5kZXggNmY5MjA1ZC4uZTJmZjE4MCAxMDA2NDQKLS0tIGEvZnMv dWRmL2JhbGxvYy5jCisrKyBiL2ZzL3VkZi9iYWxsb2MuYwpAQCAtODAxLDEyICs4MDEsMTMgQEAg c3RhdGljIGludCB1ZGZfdGFibGVfbmV3X2Jsb2NrKHN0cnVjdCBzdXBlcl9ibG9jayAqc2IsCiAJ bmV3YmxvY2sgPSBnb2FsX2Vsb2MubG9naWNhbEJsb2NrTnVtOwogCWdvYWxfZWxvYy5sb2dpY2Fs QmxvY2tOdW0rKzsKIAlnb2FsX2VsZW4gLT0gc2ItPnNfYmxvY2tzaXplOwotCi0JaWYgKGlub2Rl ICYmIGRxdW90X2FsbG9jX2Jsb2NrKGlub2RlLCAxKSkgewotCQlicmVsc2UoZ29hbF9lcG9zLmJo KTsKLQkJbXV0ZXhfdW5sb2NrKCZzYmktPnNfYWxsb2NfbXV0ZXgpOwotCQkqZXJyID0gLUVEUVVP VDsKLQkJcmV0dXJuIDA7CisJaWYgKGlub2RlKSB7CisJCSplcnIgPSBkcXVvdF9hbGxvY19ibG9j ayhpbm9kZSwgMSk7CisJCWlmICgqZXJyKSB7CisJCQlicmVsc2UoZ29hbF9lcG9zLmJoKTsKKwkJ CW11dGV4X3VubG9jaygmc2JpLT5zX2FsbG9jX211dGV4KTsKKwkJCXJldHVybiAwOworCQl9CiAJ fQogCiAJaWYgKGdvYWxfZWxlbikK --=-=-=--