From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Aneesh Kumar K.V" Subject: Re: [PATCH -V7 08/26] vfs: Add new file and directory create permission flags Date: Thu, 20 Oct 2011 10:50:08 +0530 Message-ID: <87r5285jef.fsf@linux.vnet.ibm.com> References: <1318951981-5508-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1318951981-5508-9-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20111019164216.GC30864@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: agruen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "J. Bruce Fields" Return-path: In-Reply-To: <20111019164216.GC30864-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 19 Oct 2011 12:42:16 -0400, "J. Bruce Fields" wrote: > On Tue, Oct 18, 2011 at 09:02:43PM +0530, Aneesh Kumar K.V wrote: > > From: Andreas Gruenbacher > > > > Some permission models distinguish between the permission to create a > > non-directory and a directory. Pass this information down to > > inode_permission() as mask flags > ... > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index f3ebf86..60361c6 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -67,6 +67,8 @@ struct inodes_stat_t { > > #define MAY_CHDIR 0x00000040 > > /* called from RCU mode, don't block */ > > #define MAY_NOT_BLOCK 0x00000080 > > +#define MAY_CREATE_FILE 0x00000100 > > +#define MAY_CREATE_DIR 0x00000200 > > Hm, are the flags in fs/nfsd/vfs.h going to need fixing up? > > Looking at the nfsd code.... No, I guess it's OK, nfsd does > > err = inode_permission(inode, acc & (MAY_READ|MAY_WRITE|MAY_EXEC)); > nfsd bits need fixing once nfs starts doing richacl permission check. The changes I did can be found at https://github.com/kvaneesh/linux/commits/richacl-fullset/ > So we can wait to fix up any collisions until we need to pass these > extra bits. > Yes. And that we will do once we get the VFS and local file system changes upstream. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html