From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [patch 05/10] fs: remove extra lookup in __lookup_hash Date: Wed, 18 Aug 2010 23:13:47 +0200 Message-ID: <87r5hvr5dg.fsf@basil.nowhere.org> References: <20100817183729.613117146@kernel.dk> <20100817184121.115628228@kernel.dk> <87iq38koqx.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org To: Nick Piggin Return-path: Received: from one.firstfloor.org ([213.235.205.2]:38696 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753557Ab0HRVNv (ORCPT ); Wed, 18 Aug 2010 17:13:51 -0400 In-Reply-To: <87iq38koqx.fsf@basil.nowhere.org> (Andi Kleen's message of "Wed, 18 Aug 2010 15:57:10 +0200") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Andi Kleen writes: > > and did a quick kernel build, resulting in: > > first 22753, second 22753 > > So yes it looks like the hit rate is about zero for the first case > and the change is good. I was informed that my script was buggy, here are updated numbers. hits: 22899, cycles: 59min/1771avg/223268max hits: 2784, cycles: 88min/421avg/1110max So it seems to be still rather uncommon, but not as uncommon as the first output suggested. -Andi -- ak@linux.intel.com -- Speaking for myself only.