* [PATCH] namei: make filename_parentat static
@ 2022-03-17 1:48 Jiapeng Chong
2022-03-21 18:27 ` Stephen Brennan
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-03-17 1:48 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, linux-kernel, Jiapeng Chong, Abaci Robot
This symbol is not used outside of namei.c, so marks it static.
Fix the following w1 warning:
fs/namei.c:2587:5: warning: no previous prototype for
‘filename_parentat’ [-Wmissing-prototypes].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namei.c b/fs/namei.c
index 44c366f3152f..fe3525807361 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2584,7 +2584,7 @@ static int __filename_parentat(int dfd, struct filename *name,
return retval;
}
-int filename_parentat(int dfd, struct filename *name, unsigned int flags,
+static int filename_parentat(int dfd, struct filename *name, unsigned int flags,
struct path *parent, struct qstr *last, int *type)
{
return __filename_parentat(dfd, name, flags, parent, last, type, NULL);
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] namei: make filename_parentat static
2022-03-17 1:48 [PATCH] namei: make filename_parentat static Jiapeng Chong
@ 2022-03-21 18:27 ` Stephen Brennan
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Brennan @ 2022-03-21 18:27 UTC (permalink / raw)
To: Jiapeng Chong, viro
Cc: linux-fsdevel, linux-kernel, Jiapeng Chong, Abaci Robot
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> writes:
> This symbol is not used outside of namei.c, so marks it static.
>
> Fix the following w1 warning:
>
> fs/namei.c:2587:5: warning: no previous prototype for
> ‘filename_parentat’ [-Wmissing-prototypes].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 44c366f3152f..fe3525807361 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -2584,7 +2584,7 @@ static int __filename_parentat(int dfd, struct filename *name,
> return retval;
> }
>
> -int filename_parentat(int dfd, struct filename *name, unsigned int flags,
> +static int filename_parentat(int dfd, struct filename *name, unsigned int flags,
> struct path *parent, struct qstr *last, int *type)
> {
> return __filename_parentat(dfd, name, flags, parent, last, type, NULL);
You must have based this on something other than the latest upstream
tree. Currently on v5.17 we have:
2559 static int filename_parentat(int dfd, struct filename *name,
2560 unsigned int flags, struct path *parent,
2561 struct qstr *last, int *type)
Regards,
Stephen
> --
> 2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-21 18:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-17 1:48 [PATCH] namei: make filename_parentat static Jiapeng Chong
2022-03-21 18:27 ` Stephen Brennan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).