From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sven Schnelle <svens@stackframe.org>
Subject: Re: [AFS] prevent double cell registration
Date: Tue, 25 Mar 2008 18:27:50 +0100
Message-ID: <87skye7lyh.fsf@apollo.bitebene.org>
References: <868x0bog65.fsf@deprecated.bitebene.org>
	<27146.1206465784@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org
To: David Howells <dhowells@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp.eurescom.eu ([89.31.1.171]:49510 "EHLO smtp.eurescom.eu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754121AbYCYR1z (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 25 Mar 2008 13:27:55 -0400
In-Reply-To: <27146.1206465784@redhat.com> (David Howells's message of "Tue\, 25 Mar 2008 17\:23\:04 +0000")
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

David Howells <dhowells@redhat.com> writes:

> Sven Schnelle <svens@stackframe.org> wrote:
>> kafs doesn't check if the cell already exists - so if you do an
>> echo "add newcell.org 1.2.3.4" >/proc/fs/afs/cells it will try to
>> create this cell again. kobject will also complain about a double
>> registration. To prevent such problems, return -EEXIST in that case.
>
> Hmmm...  I thought I had that covered.  Thanks.  Any chance of a Signed-off-by
> line?

oops, sorry. Here it is:

Signed-off-by: Sven Schnelle <svens@stackframe.org>

Sven.