From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list() Date: Thu, 15 Apr 2010 17:01:36 +0200 Message-ID: <87tyrc92un.fsf@basil.nowhere.org> References: <20100415085420.GT2493@dastard> <20100415185310.D1A1.A69D9226@jp.fujitsu.com> <20100415192140.D1A4.A69D9226@jp.fujitsu.com> <20100415131532.GD10966@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: KOSAKI Motohiro , Dave Chinner , Chris Mason , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org To: Mel Gorman Return-path: In-Reply-To: <20100415131532.GD10966@csn.ul.ie> (Mel Gorman's message of "Thu, 15 Apr 2010 14:15:33 +0100") Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Mel Gorman writes: > > $ stack-o-meter vmlinux-vanilla vmlinux-2-simplfy-shrink > add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-144 (-144) > function old new delta > shrink_zone 1232 1160 -72 > kswapd 748 676 -72 And the next time someone adds a new feature to these code paths or the compiler inlines differently these 72 bytes are easily there again. It's not really a long term solution. Code is tending to get more complicated all the time. I consider it unlikely this trend will stop any time soon. So just doing some stack micro optimizations doesn't really help all that much. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org