From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6465C433FF for ; Wed, 31 Jul 2019 13:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 951F0208E3 for ; Wed, 31 Jul 2019 13:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729385AbfGaNRl (ORCPT ); Wed, 31 Jul 2019 09:17:41 -0400 Received: from mga02.intel.com ([134.134.136.20]:63732 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729371AbfGaNRl (ORCPT ); Wed, 31 Jul 2019 09:17:41 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 06:17:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,330,1559545200"; d="scan'208";a="191241302" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.150]) by fmsmga001.fm.intel.com with ESMTP; 31 Jul 2019 06:17:36 -0700 From: Jani Nikula To: Masahiro Yamada , Randy Dunlap Cc: Stephen Rothwell , mm-commits@vger.kernel.org, Linux Kernel Mailing List , dri-devel , mhocko@suse.cz, linux-mm@kvack.org, Mark Brown , Linux-Next Mailing List , linux-fsdevel@vger.kernel.org, Andrew Morton Subject: Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/) In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20190704220152.1bF4q6uyw%akpm@linux-foundation.org> <80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org> <5e5353e2-bfab-5360-26b2-bf8c72ac7e70@infradead.org> Date: Wed, 31 Jul 2019 16:21:58 +0300 Message-ID: <87v9vimj9l.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, 05 Jul 2019, Masahiro Yamada wrote: > On Fri, Jul 5, 2019 at 12:23 PM Randy Dunlap wrote: >> >> On 7/4/19 8:09 PM, Masahiro Yamada wrote: >> > On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada >> > wrote: >> >> >> >> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap wrote: >> >>> >> >>> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote: >> >>>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to >> >>>> >> >>>> http://www.ozlabs.org/~akpm/mmotm/ >> >>>> >> >>>> mmotm-readme.txt says >> >>>> >> >>>> README for mm-of-the-moment: >> >>>> >> >>>> http://www.ozlabs.org/~akpm/mmotm/ >> >>> >> >>> I get a lot of these but don't see/know what causes them: >> >>> >> >>> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory >> >>> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'. Stop. >> >>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed >> >>> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2 >> >>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed >> >>> >> >> >> >> I checked next-20190704 tag. >> >> >> >> I see the empty file >> >> drivers/gpu/drm/i915/oa/Makefile >> >> >> >> Did someone delete it? >> >> >> > >> > >> > I think "obj-y += oa/" >> > in drivers/gpu/drm/i915/Makefile >> > is redundant. >> >> Thanks. It seems to be working after deleting that line. > > > Could you check whether or not > drivers/gpu/drm/i915/oa/Makefile exists in your source tree? > > Your build log says it was missing. > > But, commit 5ed7a0cf3394 ("drm/i915: Move OA files to separate folder") > added it. (It is just an empty file) > > I am just wondering why. I've sent patches adding some content, and they'll make their way upstream eventually. I am not sure why the empty file was added originally. Perhaps as a placeholder, seemed benign enough. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center