From: Gabriel Krisman Bertazi <gabriel@krisman.be>
To: "André Almeida" <andrealmeid@riseup.net>
Cc: Gabriela Bittencourt <gbittencourt@lkcamp.dev>,
linux-kselftest@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@kernel.org>,
linux-fsdevel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
David Gow <davidgow@google.com>,
kunit-dev@googlegroups.com, porlando@lkcamp.dev,
dpereira@lkcamp.dev, ~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH 1/2] unicode: kunit: refactor selftest to kunit tests
Date: Tue, 24 Sep 2024 17:40:27 -0400 [thread overview]
Message-ID: <87wmj0wx10.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <eb26f009-37e9-4988-ae86-c349af3f9a6b@riseup.net> ("André Almeida"'s message of "Tue, 24 Sep 2024 23:30:31 +0200")
André Almeida <andrealmeid@riseup.net> writes:
> Hey!
>
> On 9/23/24 19:34, Gabriela Bittencourt wrote:
>> Instead of creating 'test' functions, use kunit functions to test
>> utf-8 support in unicode subsystem.
>
> I think it would be nice to explain in the commit message what are the
> benefits of this change, why refactoring into KUnit is a good idea?
TBH, I wouldn't mind dropping this code altogether. We have similar
coverage in fstests already. It was useful when developing fs/unicode
but nowadays, it seems moot.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2024-09-24 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 17:34 [PATCH 0/2] unicode: kunit: refactor selftest to kunit tests Gabriela Bittencourt
2024-09-23 17:34 ` [PATCH 1/2] " Gabriela Bittencourt
2024-09-23 19:18 ` Shuah Khan
2024-09-23 19:39 ` Gabriel Krisman Bertazi
2024-09-24 21:30 ` André Almeida
2024-09-24 21:40 ` Gabriel Krisman Bertazi [this message]
2024-09-24 22:16 ` André Almeida
2024-09-23 17:34 ` [PATCH 2/2] unicode: kunit: change tests filename and path Gabriela Bittencourt
2024-09-23 19:19 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2024-09-22 20:16 [PATCH 0/2] unicode: kunit: refactor selftest to kunit tests Gabriela Bittencourt
2024-09-22 20:16 ` [PATCH 1/2] " Gabriela Bittencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmj0wx10.fsf@mailhost.krisman.be \
--to=gabriel@krisman.be \
--cc=andrealmeid@riseup.net \
--cc=davidgow@google.com \
--cc=dpereira@lkcamp.dev \
--cc=gbittencourt@lkcamp.dev \
--cc=krisman@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=porlando@lkcamp.dev \
--cc=skhan@linuxfoundation.org \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox