From mboxrd@z Thu Jan 1 00:00:00 1970 From: OGAWA Hirofumi Subject: Re: [patch 01/12] vfs: fix vfs_rename_dir for FS_RENAME_DOES_D_MOVE filesystems Date: Fri, 07 Aug 2009 14:00:07 +0900 Message-ID: <87ws5gz0a0.fsf@devron.myhome.or.jp> References: <200908062310.n76NA7BM012675@imap1.linux-foundation.org> <87skg42ymn.fsf@devron.myhome.or.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, mszeredi@suse.cz, hch@lst.de, mark.fasheh@oracle.com, trond.myklebust@fys.uio.no, zach.brown@oracle.com To: Sage Weil Return-path: Received: from mail.parknet.ad.jp ([210.171.162.6]:45011 "EHLO mail.officemail.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbZHGFAK (ORCPT ); Fri, 7 Aug 2009 01:00:10 -0400 In-Reply-To: (Sage Weil's message of "Thu, 6 Aug 2009 21:05:17 -0700 (PDT)") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Sage Weil writes: > FWIW, the originally proposed fix only rehashed on error, but Miklos was > worried the rehash (under any circumstances) looked racy and/or bogus. > And Al was just worried. See > > http://marc.info/?t=121580579500004&r=1&w=2 > and > http://marc.info/?t=121664078900004&r=1&w=2 > > The last word from Al (about this time last year :) was > > On Thu, 21 Aug 2008, Al Viro wrote: >> I'm still not convinced that this is right. Let me finish review of the >> current situation with dcache and rehashing, please. We definitely have >> problems in that area; the question is how to deal with all that crap >> without breaking exportfs *and* secondary roots a-la NFS ;-/ Thanks for pointer. I see. -- OGAWA Hirofumi