From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Monakhov Subject: Re: [PATCH 01/11] xfstests: add fio requirement V2 Date: Wed, 20 Feb 2013 12:14:17 +0400 Message-ID: <87y5ej767a.fsf@openvz.org> References: <1361273843-16094-1-git-send-email-dmonakhov@openvz.org> <20130220011854.GK10731@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Dave Chinner Return-path: Received: from mail-lb0-f177.google.com ([209.85.217.177]:41849 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757778Ab3BTIOW (ORCPT ); Wed, 20 Feb 2013 03:14:22 -0500 In-Reply-To: <20130220011854.GK10731@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 20 Feb 2013 12:19:21 +1100, Dave Chinner wrote: > On Tue, Feb 19, 2013 at 03:37:13PM +0400, Dmitry Monakhov wrote: > > FIO is very flexible io generator, I would call it IO swiss knife. > > Currently we have tonns of hardcoded application which reproduces > > some predefined scenario. This approach has obvious dissadvantages > > 1) Lack of flexability: one written it is hard to modify it in future > > 2) Code base is large, many routines written again and again > > > > At the same time add new fio based tast is just add simle INI file. > > This greatly simplify code review. I do beleve that some day we will > > replace most of hardcoded io binaries with fio. > > > > One who is planning to run $FIO_PROG should first check that system > > contains appropriate version which is able to handle jobfile > > for example: _require_fio 286-job.fio > > > > Signed-off-by: Dmitry Monakhov > > Hi Dimitry, > > Can you rebase this series on top of a current xfstests tree? It Ohhh. I use git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git > doesn't apply without conflicts or trying to land on top of existing > files, so that makes it hard to actually test and do a final review > on.... Will do ASAP. > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com