From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57988 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728913AbfAHVdd (ORCPT ); Tue, 8 Jan 2019 16:33:33 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x08LTN9n138074 for ; Tue, 8 Jan 2019 16:33:31 -0500 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0b-001b2d01.pphosted.com with ESMTP id 2pvyu9khyx-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 08 Jan 2019 16:33:31 -0500 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 Jan 2019 21:33:30 -0000 References: <20190108193108.GA12259@avx2> From: Thiago Jung Bauermann To: Alexey Dobriyan Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] proc: return exit code 4 for skipped tests In-reply-to: <20190108193108.GA12259@avx2> Date: Tue, 08 Jan 2019 19:33:19 -0200 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87zhsahm1s.fsf@morokweng.localdomain> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Alexey Dobriyan writes: > Test harness uses 4 for SKIP, not 2. > > Signed-off-by: Alexey Dobriyan > --- > > tools/testing/selftests/proc/proc-loadavg-001.c | 2 +- > tools/testing/selftests/proc/proc-self-map-files-002.c | 2 +- > tools/testing/selftests/proc/proc-self-syscall.c | 2 +- > tools/testing/selftests/proc/proc-self-wchan.c | 2 +- > tools/testing/selftests/proc/read.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > --- a/tools/testing/selftests/proc/proc-loadavg-001.c > +++ b/tools/testing/selftests/proc/proc-loadavg-001.c > @@ -30,7 +30,7 @@ int main(void) > > if (unshare(CLONE_NEWPID) == -1) { > if (errno == ENOSYS || errno == EPERM) > - return 2; > + return 4; > return 1; > } Can't these tests use the KSFT_SKIP macro defined in kselftest.h? -- Thiago Jung Bauermann IBM Linux Technology Center